-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Make NPCStepper.generate_local()
sync in local mode
#9
[Core] Make NPCStepper.generate_local()
sync in local mode
#9
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After thinking about it, let's keep get_action()
async; otherwise lots of parallel calls from Unity to a local API (which I'm currently setting), would block the server while waiting for the LLM's answer.
NPCStepper.generate_local()
sync in local mode
Co-authored-by: tdeborde <[email protected]>
Co-authored-by: tdeborde <[email protected]>
Co-authored-by: tdeborde <[email protected]>
Co-authored-by: tdeborde <[email protected]>
Co-authored-by: tdeborde <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change
NPCStepper.get_action()
NPCStepper.generate_local()
to synchronous function. TheREADME.md
andtests/test_step.py
files are updated accordingly.BEFORE SUBMITTING, PLEASE READ THE CHECKLIST BELOW AND FILL IN THE DESCRIPTION ABOVE
PR Checklist (Click to Expand)
Thank you for your contribution to gigax! Before submitting the pull request, please ensure the PR meets the following criteria. This helps gigax maintain the code quality and improve the efficiency of the review process.
PR Title and Classification
Only specific types of PRs will be reviewed. The PR title is prefixed appropriately to indicate the type of change. Please use one of the following:
[Bugfix]
for bug fixes.[CI/Build]
for build or continuous integration improvements.[Doc]
for documentation fixes and improvements.[Model]
for adding a new model or improving an existing model. Model name should appear in the title.[Core]
for changes in the core gigax logic[Misc]
for PRs that do not fit the above categories. Please use this sparingly.Note: If the PR spans more than one category, please include all relevant prefixes.
Code Quality
The PR need to meet the following code quality standards:
./tests
folder in the rpo.Notes for Large Changes
Please keep the changes as concise as possible. For major architectural changes, we would expect a GitHub issue (RFC) discussing the technical design and justification. Otherwise, we will tag it with
rfc-required
and might not go through the PR.What to Expect for the Reviews
The goal of the gigax team is to be a transparent reviewing machine. We would like to make the review process transparent and efficient and make sure no contributor feel confused or frustrated. However, the gigax team is small, so we need to prioritize some PRs over others. Here is what you can expect from the review process:
Thank You
Finally, thank you for taking the time to read these guidelines and for your interest in contributing to gigax.