Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

speaking the generated text #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Nish251103
Copy link

@Nish251103 Nish251103 commented Oct 3, 2020

This python program would read/speak the text for the user which is randomly generated
resolves #5

Copy link
Owner

@Git-Harshit Git-Harshit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Nish251103, have you tried running the program and testing it in your machine?

In text-to-speech.py, line 5, I can see a typo import mport instead of import, which needs to be fixed before merging your changes, else the program may raise errors and crash.

Also, the brython-script.bry is updated with the same python code as in text-to-speech.py. Why not just include the same text-to-speech.py in brython-script.bry with one line via import text-to-speech.py statement? This will help in reducing repeated code, adhering to DRY (Don't Repeat Yourself) principle.

Please do the needful so that it could be merged directly.

@Nish251103
Copy link
Author

Nish251103 commented Oct 3, 2020

import text-to-speech.py wont be needed as i added the code in the main file and also the main file works fine in my machine and the file text-to-speech.py is just for the referance.
i would request you to have a look in changes made in the file brython_script.bry
also i will correct the typo in the referance file text-to-speech.py

@Nish251103
Copy link
Author

okay i will also follow the code of conduct DRY (Don't Repeat Yourself)

@Nish251103
Copy link
Author

Kindly have a look and let me know if required more changes

@Nish251103 Nish251103 requested a review from Git-Harshit October 3, 2020 07:01
@Git-Harshit Git-Harshit added the hacktoberfest-accepted Accepted from HacktoberFest, will be merged later. label Oct 3, 2020
@Git-Harshit
Copy link
Owner

Git-Harshit commented Oct 3, 2020

Looks Good to Me! I've labelled it as hacktoberfest-accepted, for you to get proper points for your work.
Just after checking compatibility of the third-party Python modules, viz., pyttsx3, speech_recognition and difflib.SequenceMatcher, I'll be merging the changes!

Thank you for the Pull Request! 🙂

@Nish251103
Copy link
Author

Okay, Thank you also these are python libraries available at python's official website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted from HacktoberFest, will be merged later.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

speaking the generated text
2 participants