-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speaking the generated text #7
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Nish251103, have you tried running the program and testing it in your machine?
In text-to-speech.py, line 5, I can see a typo import mport
instead of import
, which needs to be fixed before merging your changes, else the program may raise errors and crash.
Also, the brython-script.bry is updated with the same python code as in text-to-speech.py. Why not just include the same text-to-speech.py in brython-script.bry with one line via import text-to-speech.py
statement? This will help in reducing repeated code, adhering to DRY (Don't Repeat Yourself) principle.
Please do the needful so that it could be merged directly.
import text-to-speech.py wont be needed as i added the code in the main file and also the main file works fine in my machine and the file text-to-speech.py is just for the referance. |
okay i will also follow the code of conduct DRY (Don't Repeat Yourself) |
Kindly have a look and let me know if required more changes |
Looks Good to Me! I've labelled it as hacktoberfest-accepted, for you to get proper points for your work. Thank you for the Pull Request! 🙂 |
Okay, Thank you also these are python libraries available at python's official website. |
This python program would read/speak the text for the user which is randomly generated
resolves #5