Share memory cache between middleware and request handler #2347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SamyPesse
reviewed
Jun 18, 2024
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
jpreynat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the work done in the middleware, since some of it is useless.The most certain one is that we call eitherget(Space|CurrentSite)LayoutDatathat fetches both the scripts and customization for the space/site. However, we only need the scripts for the current content to compute the CSP. Fetching and waiting for the customization just blocks the whole request uselessly.Then we also prefetch the space/site content data in the middleware, but I'm pretty sure that the middleware execution is isolated from the actual route handler, meaning that this prefetch viawaitUntil, even if not blocking the request, is useless.EDIT:
Since I've checked in logs that
globalThisisn't shared between the middleware and the request handlers, this PR instead makes sure that the memory cache is now properly shared between both using Cloudflare's request context.