Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse cache tags returned from the API set them in response #2349

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Parse cache tags returned from the API set them in response #2349

merged 1 commit into from
Jun 20, 2024

Conversation

jpreynat
Copy link
Member

This will allow the response from GitBook Open to set the cache-tag and x-gitbook-cache-tag headers, allowing Cloudflare to actually use them and to purge them.

@jpreynat jpreynat self-assigned this Jun 19, 2024
@argos-ci Argos CI
Copy link

argos-ci bot commented Jun 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 7 changed Jun 19, 2024, 3:37 PM

scazan
scazan approved these changes Jun 20, 2024
View reviewed changes
Copy link
Contributor

@scazan scazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know the full context here but approving cause it seems correct in that we weren't passing the tags at all previously.

@jpreynat jpreynat merged commit 56e5c3c into main Jun 20, 2024
7 of 8 checks passed
@jpreynat jpreynat deleted the fix-parsing-and-returning-cache-tags branch June 20, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scazan scazan scazan approved these changes

Assignees

@jpreynat jpreynat

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpreynat @scazan