Use a singleton to store the memory cache in an internal WeakMap for the current request #2356
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made the switch from using the
ctx
property instead of thecf
one from thegetRequestContext
in thegetGlobalContext
helper while making the memory cache from the middleware accessible to the next request handler.However, since this change was deployed, we have an increased number of these errors:
Cannot perform I/O on behalf of a different request. I/O objects (such as streams, request/response bodies, and others) created in the context of one request handler cannot be accessed from a different request's handler.
This PR reverts this change, but also switches to use the
singleton
helper to create the memory cache, that will store the memory cache and makes it accessible in aWeakMap
for the current request context.