Rework context to actually share memory cache between middleware and handlers for all requests #2358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This reverts commit 91cc246.
jpreynat
force-pushed
the
improve-memory-cache
branch
from
bbe059e to
07db53a
Compare
SamyPesse
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the existing
getGlobalContexttogetRequestContext, since thegetOptionalRequestContext().cfobject actually is in Cloudflare, and creates an actualgetGlobalContextmethod, that returnsgetOptionalRequestContext().ctxand that can be used across all executions.This PR then uses the new
getGlobalContextmethod to create the local memory cache globally and use it across all requests and between the middleware and requests handlers.