Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mermaid - Add securityLevel loose to open links in a new tab #252

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

rodrcastro
Copy link

New links can be opened in a new tab based on the Mermaid documentation. This requires the security level to be set to loose.

This PR adds the security level loose to allow for links to be opened in a new tab.

@changeset-bot
Copy link

changeset-bot bot commented Oct 3, 2023

⚠️ No Changeset found

Latest commit: 0c39f66

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@taranvohra
Copy link
Member

Hm, it's a bit risky because securityLevel: 'loose' can allow JS callbacks to be executed which makes it prone to XSS attacks. I am not really sure if we should offer it as a default behaviour. @SamyPesse any thoughts?

@addisonschultz addisonschultz added the improvement Improvement to existing integration label Apr 16, 2024
@addisonschultz
Copy link
Collaborator

PR related to issue logged: #240

@addisonschultz
Copy link
Collaborator

@rodrcastro checking back on this - is this something that users are still asking about? I'm cleaning up some PRs in this repo

@rodrcastro
Copy link
Author

@addisonschultz Nope, they didn't come back for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants