Feature/project structure #11
Conversation
| return rv | ||
|
|
||
|
|
||
| def weighted_average_power(arg, mask=None, value=0.0, **kwargs): |
There was a problem hiding this comment.
Minor (i.e. let's pick up later): could move to metrics.power
There was a problem hiding this comment.
indeed, it currently calculates both WAP and xPower - the choice is controlled by keyword 'type' with a default set to WAP. Let's see how it is being used and decide on the best strategy for moving to power.py
There was a problem hiding this comment.
Both wap and xpower are calculated from power right? Either way, can be fixed later.
| array-like | ||
| """ | ||
|
|
||
| if not isinstance(power, pd.Series): |
There was a problem hiding this comment.
Let's see if I can come up with a satisfactory solution in my "on the fly decorator type casting poc" so we can come to solution for this in #5.
| return rv | ||
|
|
||
|
|
||
| def stress_score(wap, threshold_power, duration): |
There was a problem hiding this comment.
Nice, this was first "intensity factor" right? Good job on getting rid of TrainingPeaks ;)
There was a problem hiding this comment.
It was always a stress score, but it also used to mention TSS and I've removed that.
| @@ -0,0 +1,74 @@ | |||
| from sweat.algorithms.hrm import heartrate_models | |||
There was a problem hiding this comment.
As discussed in #8 this code could also move to sweat.io.models. Since the wdf probably won't be used directly that might make sense. But can be done later when we have a clearer view of how sweat.io will work/look like.
| """ | ||
| _metadata = ['athlete'] | ||
|
|
||
| @requires(columns=['power']) |
There was a problem hiding this comment.
I will take care of ritual burning this decorator ;)
Did not do:
metrics.core.pyshould be complete