Switch localhost development to port 7777. (#4475)

* Switch localhost development to port 8888. * Use 7777 instead * Also correct port number in settings.py and goldens
GoogleChrome · Oct 24, 2024 · 30964ae · 30964ae
1 parent da48531
commit 30964ae
Show file tree

Hide file tree

Showing 18 changed files with 30 additions and 30 deletions.
diff --git a/README.md b/README.md
@@ -40,7 +40,7 @@ To start the main server and the notifier backend, run:
 ```bash
 npm start
 ```
-Then visit `http://localhost:8080/`.
+Then visit `http://localhost:7777/`.
 
 To start front end code watching (sass, js lint check, babel, minify files), run
 
@@ -128,7 +128,7 @@ Chromestatus currently gets the list of Blink components from the file `hack_com
 
 #### Seed the blink component owners
 
-Visit http://localhost:8080/admin/blink/populate_blink to see the list of Blink component owners.
+Visit http://localhost:7777/admin/blink/populate_blink to see the list of Blink component owners.
 
 #### Debugging / settings
 

diff --git a/framework/cloud_tasks_helpers.py b/framework/cloud_tasks_helpers.py
@@ -52,7 +52,7 @@ def queue_path(self, project, location, queue):
   def create_task(self, parent=None, task=None, **kwargs):
     """Immediately hit the target URL."""
     uri = task.get('app_engine_http_request').get('relative_uri')
-    target_url = 'http://localhost:8080' + uri
+    target_url = 'http://localhost:7777' + uri
     body = task.get('app_engine_http_request').get('body')
     logging.info('Making request to %r', target_url)
     handler_response = requests.request('POST',

diff --git a/framework/cloud_tasks_helpers_test.py b/framework/cloud_tasks_helpers_test.py
@@ -47,7 +47,7 @@ def test_create_task(self, mock_fetch):
     self.assertIsNone(actual)
     mock_fetch.assert_called_once_with(
       'POST',
-        'http://localhost:8080/handler',
+        'http://localhost:7777/handler',
         data=b'{"a": 1}',
         allow_redirects=False,
         headers={'X-AppEngine-QueueName': 'default'})

diff --git a/gen/py/chromestatus_openapi/Dockerfile b/gen/py/chromestatus_openapi/Dockerfile
@@ -13,4 +13,4 @@ EXPOSE 8080
 
 ENTRYPOINT ["python3"]
 
-CMD ["-m", "chromestatus_openapi"]
+CMD ["-m", "chromestatus_openapi"]
diff --git a/internals/testdata/notifier_test/test_format_email_body__new.html b/internals/testdata/notifier_test/test_format_email_body__new.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/123"
+             href="http://127.0.0.1:7777/feature/123"
              >feature template</a>
       </td>
     </tr>
@@ -67,7 +67,7 @@
 <section id="next-steps" style="margin: 16px; padding: 16px; background: white; border: 2px solid #ccc; border-radius:8px;">
   <div><b>Your next steps:</b></div>
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
+    <a href="http://127.0.0.1:7777/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
      >View feature details</a></div>
 </section>
 

diff --git a/internals/testdata/notifier_test/test_format_email_body__update_no_changes.html b/internals/testdata/notifier_test/test_format_email_body__update_no_changes.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/123"
+             href="http://127.0.0.1:7777/feature/123"
              >feature template</a>
       </td>
     </tr>
@@ -35,7 +35,7 @@
 <section id="next-steps" style="margin: 16px; padding: 16px; background: white; border: 2px solid #ccc; border-radius:8px;">
   <div><b>Your next steps:</b></div>
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
+    <a href="http://127.0.0.1:7777/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
      >View feature details</a></div>
 </section>
 

diff --git a/internals/testdata/notifier_test/test_format_email_body__update_with_changes.html b/internals/testdata/notifier_test/test_format_email_body__update_with_changes.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/123"
+             href="http://127.0.0.1:7777/feature/123"
              >feature template</a>
       </td>
     </tr>
@@ -35,7 +35,7 @@
 <section id="next-steps" style="margin: 16px; padding: 16px; background: white; border: 2px solid #ccc; border-radius:8px;">
   <div><b>Your next steps:</b></div>
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
+    <a href="http://127.0.0.1:7777/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
      >View feature details</a></div>
 </section>
 

diff --git a/internals/testdata/notifier_test/test_make_extension_approved_email.html b/internals/testdata/notifier_test/test_make_extension_approved_email.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/1"
+             href="http://127.0.0.1:7777/feature/1"
              >A feature</a>
       </td>
     </tr>
@@ -36,7 +36,7 @@
   <div><b>Your next steps:</b></div>
 
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/feature/1?gate=3&initiateExtension"
+    <a href="http://127.0.0.1:7777/feature/1?gate=3&initiateExtension"
        style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
      >Finalize trial extension</a></div>
 </section>

diff --git a/internals/testdata/reminders_test/test_build_email_tasks_escalated_feature_accuracy.html b/internals/testdata/reminders_test/test_build_email_tasks_escalated_feature_accuracy.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/123"
+             href="http://127.0.0.1:7777/feature/123"
              >feature one</a>
       </td>
     </tr>
@@ -93,7 +93,7 @@
   <div><b>Your next steps:</b></div>
 
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/guide/verify_accuracy/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
+    <a href="http://127.0.0.1:7777/guide/verify_accuracy/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
      >Verify feature accuracy</a></div>
 </section>
 

diff --git a/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy.html b/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/123"
+             href="http://127.0.0.1:7777/feature/123"
              >feature one</a>
       </td>
     </tr>
@@ -88,7 +88,7 @@
   <div><b>Your next steps:</b></div>
 
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/guide/verify_accuracy/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
+    <a href="http://127.0.0.1:7777/guide/verify_accuracy/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
      >Verify feature accuracy</a></div>
 </section>
 

diff --git a/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy_enterprise.html b/internals/testdata/reminders_test/test_build_email_tasks_feature_accuracy_enterprise.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/123"
+             href="http://127.0.0.1:7777/feature/123"
              >feature one</a>
       </td>
     </tr>
@@ -88,7 +88,7 @@
   <div><b>Your next steps:</b></div>
 
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/guide/verify_accuracy/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
+    <a href="http://127.0.0.1:7777/guide/verify_accuracy/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
      >Verify feature accuracy</a></div>
 </section>
 

diff --git a/internals/testdata/reminders_test/test_build_email_tasks_prepublication.html b/internals/testdata/reminders_test/test_build_email_tasks_prepublication.html
@@ -16,7 +16,7 @@
     </tr>
     <tr>
       <td><a style="font-size: 140%;"
-             href="http://127.0.0.1:8888/feature/123"
+             href="http://127.0.0.1:7777/feature/123"
              >feature one</a>
       </td>
     </tr>
@@ -43,7 +43,7 @@
 
   <h2>1. Locate your releases on the roadmap.</h2>
   <p>Please check where your feature appears on the
-    <a href="http://127.0.0.1:8888/roadmap">roadmap page</a>.
+    <a href="http://127.0.0.1:7777/roadmap">roadmap page</a>.
     If your feature does not appear, you may need to fill in
     milestone values or update the feature's implementation status.
     Be sure that you have gotten all needed approvals.</p>
@@ -70,7 +70,7 @@ <h3>feature one</h3>
   </div>
 
   <div style="margin: 16px;">
-    <a href="http://127.0.0.1:8888/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
+    <a href="http://127.0.0.1:7777/feature/123" style="text-decoration: none; font-weight: bold; color: white; background: #01579b; border-radius: 8px; padding: 8px 16px; "
        >View feature details</a></div>
 
   <p>Guidelines for writing the summary:</p>

diff --git a/main.py b/main.py
@@ -367,4 +367,4 @@ class Route:
     # This is used when running locally only. When deploying to Google App
     # Engine, a webserver process such as Gunicorn will serve the app. This
     # can be configured by adding an `entrypoint` to app.yaml.
-    app.run(host='127.0.0.1', port=8080)
+    app.run(host='127.0.0.1', port=7777)
diff --git a/packages/playwright/docker-compose.yml b/packages/playwright/docker-compose.yml
@@ -69,7 +69,7 @@ services:
     command: bash -c "source cs-env/bin/activate; env && whoami && npm run start-app"
     network_mode: host
     healthcheck:
-      test: ["CMD", "curl", "-f", "http://localhost:8080"]
+      test: ["CMD", "curl", "-f", "http://localhost:7777"]
       interval: 30s
       timeout: 10s
       retries: 10

diff --git a/packages/playwright/playwright.config.cjs b/packages/playwright/playwright.config.cjs
@@ -30,7 +30,7 @@ module.exports = defineConfig({
   /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
   use: {
     /* Base URL to use in actions like `await page.goto('/')`. */
-    baseURL: 'http://localhost:8080',
+    baseURL: 'http://localhost:7777',
 
     /* Collect trace when retrying the failed test. See https://playwright.dev/docs/trace-viewer */
     trace: 'on-first-retry',
@@ -98,7 +98,7 @@ module.exports = defineConfig({
   /* Run your local dev server before starting the tests */
   webServer: {
     command: 'npm run start',
-    url: 'http://localhost:8080',
+    url: 'http://localhost:7777',
     reuseExistingServer: true,
   },
 });
diff --git a/packages/playwright/wait-for-app.sh b/packages/playwright/wait-for-app.sh
@@ -1,6 +1,6 @@
 #!/bin/bash
 # echo "waiting for backend to come up"
-while [[ "$(curl --connect-timeout 2 -s -o /dev/null -w ''%{http_code}'' http://localhost:8080)" != "200" ]]; do
+while [[ "$(curl --connect-timeout 2 -s -o /dev/null -w ''%{http_code}'' http://localhost:7777)" != "200" ]]; do
     echo ..
     sleep 10
 done

diff --git a/scripts/start_server.sh b/scripts/start_server.sh
@@ -11,7 +11,7 @@ export GAE_ENV='localdev'
 export DATASTORE_EMULATOR_HOST=${DATASTORE_EMULATOR_HOST:-'localhost:15606'}
 
 
-gunicorn --bind :8080 --workers 4 main:app
+gunicorn --bind :7777 --workers 4 main:app
 
 
 # TODO(jrobbins): Consider switching back to dev_appserver when

diff --git a/settings.py b/settings.py
@@ -95,11 +95,11 @@ def get_flask_template_path() -> str:
 
 if UNIT_TEST_MODE:
   APP_TITLE = 'Local testing'
-  SITE_URL = 'http://127.0.0.1:8888/'
+  SITE_URL = 'http://127.0.0.1:7777/'
 elif DEV_MODE:
   PROD = False
   APP_TITLE = 'Chrome Status Dev'
-  SITE_URL = 'http://127.0.0.1:8888/'
+  SITE_URL = 'http://127.0.0.1:7777/'
 elif APP_ID == 'cr-status':
   PROD = True
   DEBUG = False