Skip to content

Commit

Permalink
Add omole as an enterprise reviewer. (#4450)
Browse files Browse the repository at this point in the history
* Add omole as an enterprise reviewer.

* updated tests
  • Loading branch information
jrobbins authored Oct 16, 2024
1 parent 28866b6 commit 85aa6e2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 6 deletions.
1 change: 1 addition & 0 deletions internals/approval_defs.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
'[email protected]',
'[email protected]',
'[email protected]',
'[email protected]',
]
DEBUGGABILITY_APPROVERS = IN_NDB
TESTING_APPROVERS = [
Expand Down
15 changes: 9 additions & 6 deletions internals/reminders_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -400,11 +400,12 @@ def test_get_template_data__one_due_unassigned(self, mock_remaining_days):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'3 email(s) sent or logged.\n'
expected_message = (f'4 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]')
'[email protected]\n'
'[email protected]')
expected = {'message': expected_message}
self.assertEqual(actual, expected)

Expand Down Expand Up @@ -437,11 +438,12 @@ def test_get_template_data__one_overdue_unassigned(self, mock_remaining_days):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'3 email(s) sent or logged.\n'
expected_message = (f'4 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]')
'[email protected]\n'
'[email protected]')
expected = {'message': expected_message}
self.assertEqual(actual, expected)

Expand All @@ -457,12 +459,13 @@ def test_get_template_data__one_overdue_assigned(self, mock_remaining_days):
with test_app.app_context():
actual = self.handler.get_template_data()

expected_message = (f'4 email(s) sent or logged.\n'
expected_message = (f'5 email(s) sent or logged.\n'
'Recipients:\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]\n'
'[email protected]')
'[email protected]\n'
'[email protected]')
expected = {'message': expected_message}
self.assertEqual(actual, expected)

Expand Down

0 comments on commit 85aa6e2

Please sign in to comment.