Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight outdated feature entries on roadmap #4472

Merged
merged 6 commits into from
Oct 24, 2024
Merged

Highlight outdated feature entries on roadmap #4472

merged 6 commits into from
Oct 24, 2024

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented Oct 21, 2024 •
edited
Loading

Highlight outdated feature entries for two upcoming milestones through an error icon.

  • A feature is highlighted if it is scheduled to ship in the next 2 milestones, and its accurate_as_of date is at least 4 weeks ago. The upcoming milestones are determined by stable_version + 1 and + 2
  • On the backend, plumb accurate_as_of information to the roadmap page.

A part of 4370

UI

Screenshot 2024-10-21 4 43 30 PM

@KyleJu KyleJu changed the title Add outdated logic on Roadmap page Highlight outdated feature entries on roadmap Oct 21, 2024
@KyleJu KyleJu marked this pull request as ready for review October 21, 2024 23:49
@KyleJu
Copy link
Collaborator Author

KyleJu commented Oct 21, 2024

@jyasskin I started on the roadmap page and used an error icon to highlight the outdated feature entries. Let me know what you think!

jyasskin
jyasskin reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a reasonable UI for the roadmap. I assume you're planning for the matching UI on the feature page to link to the feature's verification page so that owners can easily clear the warning. Thanks!

client-src/elements/chromedash-roadmap-milestone-card.ts Outdated Show resolved Hide resolved
client-src/elements/chromedash-roadmap-milestone-card.ts Outdated Show resolved Hide resolved
client-src/elements/chromedash-roadmap-milestone-card.ts Outdated Show resolved Hide resolved
client-src/elements/chromedash-roadmap-milestone-card.ts Outdated Show resolved Hide resolved
jrobbins
jrobbins reviewed Oct 22, 2024
View reviewed changes
Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me, after Jeffrey's comments are resolved.

@KyleJu KyleJu merged commit bbfa6c8 into main Oct 24, 2024
7 checks passed
@KyleJu KyleJu deleted the oudated-backend branch October 24, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jyasskin jyasskin jyasskin approved these changes

@jrobbins jrobbins Awaiting requested review from jrobbins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KyleJu @jrobbins @jyasskin