-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Keep features up-to-date in the Feature Detail page #4481
Conversation
d4105be
to
e973cba
Compare
@jyasskin This is a draft PR. Any opinions on the UI above? I can change the background color of the overview section and further highlight the warning, e.g. |
@jrobbins A quick question on the TODO - do I have to iterate through stage.extensions to find all STAGE_TYPES_SHIPPING milestones? |
UI ready
e973cba
to
779b9ed
Compare
346f845
to
d338fd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after considering some name changes.
Also, please update the screenshots in the PR description because it seems that the wording of the messages was changed.
I think the all-orange overview box is too dark. Let's stick to just the warning banner above the overview. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't reviewed the test in detail, and I try to avoid having opinions on colors, but the design looks good. Thanks!
The screenshots in the PR description were updated, but my all-orange overview box comment had an updated screenshot. |
Implement a UI to show outdated feature warnings in the feature detail page. #4370. It shows a warning banner below the title based on the audience, if outdated.
For a feature author:
For a feature reader:
Follow-up
Send a follow-up PR for the case where a feature has not been verified since it is shipped.