Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep features up-to-date in the Feature Detail page #4481

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

KyleJu
Copy link
Collaborator

@KyleJu KyleJu commented Oct 25, 2024

Implement a UI to show outdated feature warnings in the feature detail page. #4370. It shows a warning banner below the title based on the audience, if outdated.

For a feature author:
Screenshot 2024-10-29 3 36 01 PM

For a feature reader:
Screenshot 2024-10-29 3 36 19 PM

Follow-up

Send a follow-up PR for the case where a feature has not been verified since it is shipped.

@KyleJu
Copy link
Collaborator Author

KyleJu commented Oct 29, 2024

@jyasskin This is a draft PR. Any opinions on the UI above? I can change the background color of the overview section and further highlight the warning, e.g.
Screenshot 2024-10-28 5 17 57 PM

@KyleJu
Copy link
Collaborator Author

KyleJu commented Oct 29, 2024

@jrobbins A quick question on the TODO - do I have to iterate through stage.extensions to find all STAGE_TYPES_SHIPPING milestones?

@KyleJu KyleJu changed the title [Draft] Keep features up-to-date in the Feature Detail page Keep features up-to-date in the Feature Detail page Oct 30, 2024
@KyleJu KyleJu marked this pull request as ready for review October 30, 2024 00:18
@KyleJu KyleJu requested a review from jyasskin October 30, 2024 00:18
Copy link
Collaborator

@jrobbins jrobbins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after considering some name changes.

Also, please update the screenshots in the PR description because it seems that the wording of the messages was changed.

client-src/elements/chromedash-feature-page.ts Outdated Show resolved Hide resolved
client-src/elements/chromedash-feature-page.ts Outdated Show resolved Hide resolved
@jrobbins
Copy link
Collaborator

@jyasskin This is a draft PR. Any opinions on the UI above? I can change the background color of the overview section and further highlight the warning, e.g. Screenshot 2024-10-28 5 17 57 PM

I think the all-orange overview box is too dark. Let's stick to just the warning banner above the overview.

Copy link
Collaborator

@jyasskin jyasskin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed the test in detail, and I try to avoid having opinions on colors, but the design looks good. Thanks!

client-src/elements/chromedash-feature-page.ts Outdated Show resolved Hide resolved
client-src/elements/chromedash-feature-page.ts Outdated Show resolved Hide resolved
client-src/elements/chromedash-feature-page.ts Outdated Show resolved Hide resolved
@KyleJu
Copy link
Collaborator Author

KyleJu commented Oct 30, 2024

LGTM after considering some name changes.

Also, please update the screenshots in the PR description because it seems that the wording of the messages was changed.

The screenshots in the PR description were updated, but my all-orange overview box comment had an updated screenshot.

@KyleJu KyleJu merged commit 59a1e11 into main Oct 30, 2024
6 of 7 checks passed
@KyleJu KyleJu deleted the accurate-feature-detail branch October 30, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants