Skip to content
This repository has been archived by the owner on Mar 14, 2024. It is now read-only.

Fix memory leak in code sample #4982

Merged
merged 1 commit into from
Jan 23, 2023
Merged

Fix memory leak in code sample #4982

merged 1 commit into from
Jan 23, 2023

Conversation

beaufortfrancois
Copy link
Member

Fixes #4894

@netlify
Copy link

netlify bot commented Jan 20, 2023 •
edited
Loading

✅ Deploy Preview for developer-chrome-com ready!

Name Link
🔨 Latest commit cc07f14
🔍 Latest deploy log https://app.netlify.com/sites/developer-chrome-com/deploys/63ca6537b06cef0008364abb
😎 Deploy Preview https://deploy-preview-4982--developer-chrome-com.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions
Copy link

github-actions bot commented Jan 20, 2023 •
edited
Loading

Staging build for commit d162c51 started at 2023-01-20T09:56:07Z completed after 5.95 minutes.

https://pr-4982-static-dot-dcc-staging.uc.r.appspot.com/

The following pages likely changed with this PR:

@beaufortfrancois beaufortfrancois mentioned this pull request Jan 20, 2023
Closed
@beaufortfrancois
Copy link
Member Author

@rachelandrew Please review.

@beaufortfrancois beaufortfrancois merged commit 774345c into main Jan 23, 2023
@beaufortfrancois beaufortfrancois deleted the beaufortfrancois-patch-1 branch January 23, 2023 12:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rachelandrew rachelandrew rachelandrew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Snippet in article about setSinkId() may cause a memory leak
2 participants
@beaufortfrancois @rachelandrew