deps: upgrade typescript to 5.5.3 #16091

connorjclark · 2024-06-27T19:58:43Z

Upgrades typescript from 5.0.4 to 5.52

....or rather, tries to. I found that 5.1 has introduced errors that I cannot resolve:

yarn run v1.22.19
$ tsc --build ./tsconfig-all.json
core/gather/session.js(137,33): error TS2769: No overload matches this call.
  Overload 1 of 2, '(timeoutId: string | number | Timeout | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'string | number | Timeout | undefined'.
      Property '[Symbol.dispose]' is missing in type 'Timer' but required in type 'Timeout'.
  Overload 2 of 2, '(id: number | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'number'.
core/gather/driver/wait-for-condition.js(151,35): error TS2769: No overload matches this call.
  Overload 1 of 2, '(timeoutId: string | number | Timeout | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'string | number | Timeout | undefined'.
  Overload 2 of 2, '(id: number | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'number'.
core/gather/driver/wait-for-condition.js(196,37): error TS2769: No overload matches this call.
  Overload 1 of 2, '(timeoutId: string | number | Timeout | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'string | number | Timeout | undefined'.
  Overload 2 of 2, '(id: number | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'number'.
core/gather/driver/wait-for-condition.js(270,37): error TS2769: No overload matches this call.
  Overload 1 of 2, '(timeoutId: string | number | Timeout | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'string | number | Timeout | undefined'.
  Overload 2 of 2, '(id: number | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'number'.
core/gather/driver/wait-for-condition.js(370,35): error TS2769: No overload matches this call.
  Overload 1 of 2, '(timeoutId: string | number | Timeout | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'string | number | Timeout | undefined'.
  Overload 2 of 2, '(id: number | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'number'.
core/gather/driver/wait-for-condition.js(528,36): error TS2769: No overload matches this call.
  Overload 1 of 2, '(timeoutId: string | number | Timeout | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'string | number | Timeout | undefined'.
  Overload 2 of 2, '(id: number | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'number'.
cli/run.js(96,3): error TS2322: Type 'any' is not assignable to type 'never'.
cli/run.js(102,3): error TS2322: Type 'any' is not assignable to type 'never'.
cli/run.js(114,3): error TS2322: Type 'any' is not assignable to type 'never'.
cli/sentry-prompt.js(50,48): error TS2769: No overload matches this call.
  Overload 1 of 2, '(timeoutId: string | number | Timeout | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'string | number | Timeout | undefined'.
  Overload 2 of 2, '(id: number | undefined): void', gave the following error.
    Argument of type 'Timer' is not assignable to parameter of type 'number'.
core/gather/gatherers/link-elements.js(106,7): error TS2322: Type '{ supportedModes: ("navigation" | "timespan")[]; dependencies: { DevtoolsLog: symbol; }; }' is not assignable to type 'GathererMetaNoDependencies'.
  Object literal may only specify known properties, and 'dependencies' does not exist in type 'GathererMetaNoDependencies'.
core/lib/proto-preprocessor.js(137,24): error TS7006: Parameter 'flag' implicitly has an 'any' type.
core/lib/proto-preprocessor.js(138,25): error TS7006: Parameter 'flag' implicitly has an 'any' type.
core/scripts/manual-chrome-launcher.js(27,37): error TS7006: Parameter 'flag' implicitly has an 'any' type.
core/scripts/manual-chrome-launcher.js(29,39): error TS7006: Parameter 'flag' implicitly has an 'any' type.
core/scripts/manual-chrome-launcher.js(32,49): error TS7006: Parameter 'flag' implicitly has an 'any' type.
core/scripts/manual-chrome-launcher.js(40,27): error TS7006: Parameter 'flag' implicitly has an 'any' type.
core/test/config/validation-test.js(92,9): error TS2322: Type '{ id: string; gatherer: { instance: LinkElements; }; dependencies: { DevtoolsLog: { id: string; }; }; }' is not assignable to type 'AnyArtifactDefn'.
  The types of 'gatherer.instance.meta' are incompatible between these types.
    Property 'dependencies' is missing in type 'GathererMetaNoDependencies' but required in type 'GathererMetaWithDependencies<"DevtoolsLog">'.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

summarizing above:

Inside Node code, setTimeout seems to be using the browser definition instead of the Node one, so it doesn't like us giving it NodeJS.Timeout
Inside node code, process is any so many cascading errors from that in cli
Something funky with LH.Gatherer.GathererMeta

yarn.lock

connorjclark · 2024-06-27T20:06:17Z

types/internal/query-selector.d.ts

-  TagNames extends Array<string> ?
-    HtmlAndSvgElementTagNameMap[TagNames[number]] :
+  TagNames extends string ?
+    HtmlAndSvgElementTagNameMap[TagNames] :
    Element: // Fall back for queries typed-query-selector fails to parse, e.g. `'[alt], [aria-label]'`.


the query selector type library broke in a 5.x, and in upgrading I found that their API changed from an array of tags to just a union.

connorjclark · 2024-06-28T21:29:12Z

process issue: the process-global.js file was mucking things up. adding to tsconfig exclude

clearTimeout issue: we were using an older interface - NodeJS.Timer - which is no longer getting updates. Such as adding the dispose symbol. I filed a bug

remaining:

core/gather/gatherers/link-elements.js(106,7): error TS2353: Object literal may only specify known properties, and 'dependencies' does not exist in type 'GathererMetaNoDependencies'.
core/test/config/validation-test.js(92,9): error TS2322: Type '{ id: string; gatherer: { instance: LinkElements; }; dependencies: { DevtoolsLog: { id: string; }; }; }' is not assignable to type 'AnyArtifactDefn'.
  The types of 'gatherer.instance.meta' are incompatible between these types.
    Property 'dependencies' is missing in type 'GathererMetaNoDependencies' but required in type 'GathererMetaWithDependencies<"DevtoolsLog">'.

connorjclark · 2024-07-01T20:16:02Z

I ran a bisect over typescript

every-ts bisect start 5.5.2 5.0.4 --
every-ts bisect run sh -c "(tsc --build ./tsconfig-all.json || true) | (! grep -q 'GathererMetaNoDependencies')"

looks very related: microsoft/TypeScript@615a97b

connorjclark · 2024-07-01T20:39:36Z

core/gather/gatherers/link-elements.js

-    /**
-     * This needs to be in the constructor.
-     * https://github.com/GoogleChrome/lighthouse/issues/12134
-     * @type {LH.Gatherer.GathererMeta<'DevtoolsLog'>}


this was true for browserify

adamraine · 2024-07-01T21:53:12Z

cli/cli-flags.js

@@ -389,7 +389,7 @@ function coerceOptionalStringBoolean(value) {
 function coerceOutput(values) {
  const outputTypes = ['json', 'html', 'csv'];
  const errorHint = `Argument 'output' must be an array from choices "${outputTypes.join('", "')}"`;
-  if (!values.every(/** @return {item is string} */ item => typeof item === 'string')) {


yarn.lock

connorjclark changed the title ~~wip~~ deps: upgrade typescript to 5.5.2 Jun 27, 2024

connorjclark commented Jun 27, 2024

View reviewed changes

yarn.lock Outdated Show resolved Hide resolved

connorjclark commented Jun 27, 2024

View reviewed changes

vercel bot deployed to Preview June 28, 2024 21:12 View deployment

vercel bot deployed to Preview June 28, 2024 21:29 View deployment

connorjclark added 4 commits July 1, 2024 12:39

wip

ffa9dc6

trying to update

4eb1ca6

resolve errors with process

9141bdb

fix clearTimeout issue

3af986d

workaround weird tsc bug

365c065

connorjclark force-pushed the upgrade-ts-5.5 branch from d2b5fde to 365c065 Compare July 1, 2024 20:39

connorjclark marked this pull request as ready for review July 1, 2024 20:39

connorjclark requested a review from a team as a code owner July 1, 2024 20:39

connorjclark requested review from adamraine and removed request for a team July 1, 2024 20:39

connorjclark commented Jul 1, 2024

View reviewed changes

vercel bot deployed to Preview July 1, 2024 20:40 View deployment

devtools-bot assigned adamraine Jul 1, 2024

devtools-bot added the waiting4reviewer label Jul 1, 2024

connorjclark added 3 commits July 1, 2024 14:21

remove @tag test case

0d37678

update generated/

e2e6b10

remove some explicit type predicates

048d31f

vercel bot deployed to Preview July 1, 2024 21:25 View deployment

adamraine reviewed Jul 2, 2024

View reviewed changes

set types/node pkg

2d499d7

vercel bot deployed to Preview July 3, 2024 19:42 View deployment

5.5.3

b226a2a

vercel bot deployed to Preview July 3, 2024 19:44 View deployment

adamraine approved these changes Jul 3, 2024

View reviewed changes

connorjclark changed the title ~~deps: upgrade typescript to 5.5.2~~ deps: upgrade typescript to 5.5.3 Jul 3, 2024

connorjclark merged commit a21fde7 into main Jul 3, 2024
27 checks passed

connorjclark deleted the upgrade-ts-5.5 branch July 3, 2024 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: upgrade typescript to 5.5.3 #16091

deps: upgrade typescript to 5.5.3 #16091

connorjclark commented Jun 27, 2024 •

edited

Loading

connorjclark Jun 27, 2024

connorjclark commented Jun 28, 2024 •

edited

Loading

connorjclark commented Jul 1, 2024 •

edited

Loading

connorjclark Jul 1, 2024

adamraine Jul 1, 2024

deps: upgrade typescript to 5.5.3 #16091

deps: upgrade typescript to 5.5.3 #16091

Conversation

connorjclark commented Jun 27, 2024 • edited Loading

connorjclark Jun 27, 2024

Choose a reason for hiding this comment

connorjclark commented Jun 28, 2024 • edited Loading

connorjclark commented Jul 1, 2024 • edited Loading

connorjclark Jul 1, 2024

Choose a reason for hiding this comment

adamraine Jul 1, 2024

Choose a reason for hiding this comment

connorjclark commented Jun 27, 2024 •

edited

Loading

connorjclark commented Jun 28, 2024 •

edited

Loading

connorjclark commented Jul 1, 2024 •

edited

Loading