misc(ci): fix deprecated node usage in ci.yml
#16095
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamirmahal
changed the title
deprecated node usage in ci.yml
hamirmahal
commented
Jun 29, 2024
.github/workflows/ci.yml
Outdated
| name: dist | ||
| path: dist/ | ||
| - name: Upload dist | ||
| uses: actions/upload-artifact@v4 |
There was a problem hiding this comment.
This was using a version of actions/upload-artifact that is scheduled for deprecation, so I updated it to the latest major version.
There was a problem hiding this comment.
Thanks, but can you get rid of all these other whitespace changes?
There was a problem hiding this comment.
You're welcome, and sure; I removed the changes from formatting on save.
`scheduled for deprecation`
hamirmahal
force-pushed
the
fix/usage-of-deprecated-actions-ci-yml
branch
from
b9f8ff4
to
40df8de
Compare
|
closing for #16191 (there's many usages of these things, so gotta update them all) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change makes it so that
ci.ymldoesn't useactions/setup-node@v3, which uses adeprecatedversion ofNode.js.Related Issues/PRs
This pull request fixes #16094.