Use fancy md notes #503
Merged
Use fancy md notes #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipwalton
approved these changes
Jul 15, 2024
|
Looks like it was caused by a multi-line note. Prettier fixed it by adding the blockquote syntax, although we could have also just made it a single-line note. Went with the prettier fix and the linter seems to be happy now. |
Ahh, just saw this comment, my preference would be to make it a single line so it's consistent with the other notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of GitHub's fancy note/warning UI in markdown, which helps them stand out. Use the rich diff to see the effects.
Also converted a few places that talk about FID deprecation to use a more noticeable "Caution" UI.