-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test flakiness #507
Conversation
I reverted the checks that would skip some tests in browsers that don't support prerender. I don't think the prerender-stubbing code was the cause of the flakiness, I think it was mainly the issue we discovered with the IMO it only makes sense to skip the check if we're actually triggering a prerender load somehow. If we're stubbing it then I think running the tests in all browsers is still useful to check that out assumptions of how things work are interoperable. |
I've run the tests three times in a row now and they've all passed each time. |
Makes the following improvements:
web-vitals/attribution
usingbrowserify
#486 as no longer required as discussed in: https://bugzilla.mozilla.org/show_bug.cgi?id=1893921interactive
for the LCP image after hidden test as LCP doesn't always seem to be reported without this in all browsers.