Add table and logic to store discouraged details #1211
+309
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcscottiii
added a commit
that referenced
this pull request
Feb 25, 2025
This change modifies the web features workflow to call the spanner logic that inserts discouraged details (if those details exist for a feature) Builds on #1211
This change adds a new table: FeatureDiscouragedDetails It is setup to have a foreign key with its corresponding Web Feature. The other fields come from [web features](https://github.com/web-platform-dx/web-features/blob/1332db1a8ceb74af13fbcb58ee8501aa2b948f71/schemas/data.schema.json#L60-L81). We don't plan on querying for individual details in AccordingTo and Alternatives. Those two fields are marked as nullable because we may get rid of them in the future.
jcscottiii
force-pushed
the
jcscottiii/store-discouraged-details-spanner
branch
from
f236bc8 to
afca1b8
Compare
jcscottiii
added a commit
that referenced
this pull request
Feb 25, 2025
This change modifies the web features workflow to call the spanner logic that inserts discouraged details (if those details exist for a feature) Builds on #1211
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new table: FeatureDiscouragedDetails
It is setup to have a foreign key with its corresponding Web Feature.
The other fields come from web features.
We don't plan on querying for individual details in AccordingTo and Alternatives. Those two fields are marked as nullable because we may get rid of them in the future.