fix: support correct to base64 for non-latin (#3031)

Closes #3019
GoogleChromeLabs · Jan 24, 2025 · 6fe665f · 6fe665f
1 parent 7c7de38
commit 6fe665f
Show file tree

Hide file tree

Showing 4 changed files with 91 additions and 3 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -152,7 +152,7 @@ export default [
       'plugin:@typescript-eslint/recommended-requiring-type-checking',
     )
     .map((config) => ({
-      name: 'Plugin rules',
+      name: 'TypeScript plugins',
       ...config,
       files: ['**/*.ts'],
     })),
@@ -258,7 +258,6 @@ export default [
       ],
     },
   },
-
   {
     name: 'Fix test unused',
     files: ['**/*.ts'],

diff --git a/src/bidiMapper/modules/network/NetworkRequest.ts b/src/bidiMapper/modules/network/NetworkRequest.ts
@@ -45,6 +45,7 @@ import {
   computeHeadersSize,
   getTiming,
   networkHeaderFromCookieHeaders,
+  stringToBase64,
 } from './NetworkUtils.js';
 
 const REALM_REGEX = /(?<=realm=").*(?=")/;
@@ -1105,7 +1106,7 @@ function getCdpBodyFromBiDiBytesValue(
 ): string | undefined {
   let parsedBody: string | undefined;
   if (body?.type === 'string') {
-    parsedBody = btoa(body.value);
+    parsedBody = stringToBase64(body.value);
   } else if (body?.type === 'base64') {
     parsedBody = body.value;
   }

diff --git a/src/bidiMapper/modules/network/NetworkUtils.ts b/src/bidiMapper/modules/network/NetworkUtils.ts
@@ -33,6 +33,25 @@ export function computeHeadersSize(headers: Network.Header[]): number {
   return new TextEncoder().encode(requestHeaders).length;
 }
 
+export function stringToBase64(str: string): string {
+  return typedArrayToBase64(new TextEncoder().encode(str));
+}
+
+function typedArrayToBase64(typedArray: Uint8Array): string {
+  // chunkSize should be less V8 limit on number of arguments!
+  // https://github.com/v8/v8/blob/d3de848bea727518aee94dd2fd42ba0b62037a27/src/objects/code.h#L444
+  const chunkSize = 65534;
+  const chunks = [];
+
+  for (let i = 0; i < typedArray.length; i += chunkSize) {
+    const chunk = typedArray.subarray(i, i + chunkSize);
+    chunks.push(String.fromCodePoint.apply(null, chunk as unknown as number[]));
+  }
+
+  const binaryString = chunks.join('');
+  return btoa(binaryString);
+}
+
 /** Converts from CDP Network domain headers to BiDi network headers. */
 export function bidiNetworkHeadersFromCdpNetworkHeaders(
   headers?: Protocol.Network.Headers,

diff --git a/tests/network/test_provide_response.py b/tests/network/test_provide_response.py
@@ -486,3 +486,72 @@ async def test_provide_response_remove_intercept_inflight_request(
         },
         "type": "event",
     }
+
+
+@pytest.mark.asyncio
+async def test_provide_response_works_with_non_latin(websocket, context_id,
+                                                     url_example):
+    await subscribe(websocket,
+                    ["network.responseStarted", "network.responseCompleted"],
+                    [context_id])
+
+    await execute_command(
+        websocket, {
+            "method": "network.addIntercept",
+            "params": {
+                "phases": ["responseStarted"],
+                "urlPatterns": [{
+                    "type": "string",
+                    "pattern": url_example,
+                }, ],
+            },
+        })
+
+    await send_JSON_command(
+        websocket, {
+            "method": "browsingContext.navigate",
+            "params": {
+                "url": url_example,
+                "context": context_id,
+                "wait": "complete",
+            }
+        })
+
+    event_response = await wait_for_event(websocket, "network.responseStarted")
+    network_id = event_response["params"]["request"]["request"]
+
+    await execute_command(
+        websocket, {
+            "method": "network.provideResponse",
+            "params": {
+                "request": network_id,
+                "headers": [{
+                    "name": "Content-Type",
+                    "value": {
+                        "type": "string",
+                        "value": "text/plain; charset=utf-8",
+                    }
+                }],
+                "body": {
+                    "type": "string",
+                    "value": "Hello 🌍!",
+                },
+            },
+        })
+
+    event_response = await wait_for_event(websocket,
+                                          "network.responseCompleted")
+
+    result = await execute_command(
+        websocket, {
+            "method": "script.evaluate",
+            "params": {
+                "expression": "document.documentElement.innerText",
+                "target": {
+                    "context": context_id
+                },
+                "awaitPromise": False,
+            }
+        })
+
+    assert result['result']['value'] == "Hello 🌍!"