Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Formatter #71

Merged
merged 3 commits into from
Nov 28, 2023
Merged

Configure Formatter #71

merged 3 commits into from
Nov 28, 2023

Conversation

ycheng627
Copy link
Collaborator

Add formatter and run formatter on source files.

@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2023

Codecov Report

Attention: 35 lines in your changes are missing coverage. Please review.

Comparison is base (3d4be2b) 61.37% compared to head (510a669) 61.39%.

Files Patch % Lines
...rc/app/events/events-card/events-card.component.ts 33.33% 9 Missing and 1 partial ⚠️
...ics/diagnostics-card/diagnostics-card.component.ts 38.46% 8 Missing ⚠️
...ostics-app/src/app/core/services/events.service.ts 60.00% 6 Missing ⚠️
...stics-dashboard/diagnostics-dashboard.component.ts 25.00% 3 Missing ⚠️
...lemetry/telemetry-card/telemetry-card.component.ts 66.66% 2 Missing and 1 partial ⚠️
diagnostics-extension/src/utils.ts 50.00% 2 Missing ⚠️
...ents-card-content/events-card-content.component.ts 50.00% 1 Missing ⚠️
...y-card-content/telemetry-card-content.component.ts 50.00% 1 Missing ⚠️
diagnostics-extension/src/controllers/telemetry.ts 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #71      +/-   ##
==========================================
+ Coverage   61.37%   61.39%   +0.01%     
==========================================
  Files          25       25              
  Lines         466      474       +8     
  Branches       51       51              
==========================================
+ Hits          286      291       +5     
- Misses        177      180       +3     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ycheng627 ycheng627 changed the title Format Configure Formatter Nov 27, 2023
Add the formatter rules and scripts to invoke the formatter.

Prettier with custom config is used in the project.

BUG=b/308944438
Run the prettier formatter on all app source file.

BUG=b/308944438
Run the prettier formatter on all extension source file.

BUG=b/308944438
@ycheng627 ycheng627 merged commit bc2afe1 into main Nov 28, 2023
5 checks passed
@ycheng627 ycheng627 deleted the yycheng/format branch November 28, 2023 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants