Fix Test and declare module #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ycheng627
commented
Dec 6, 2023
ycheng627
commented
- Fix npm test script to run with presubmit
- Fix any linting problem
- Declare extension code to use ECMAScript Module, and modify any CommonJS code to use .cjs file type
Currently, CI script runs the `test:ci` script, which does not check for linting error. There is no need to maintain two separate scripts (`test` and `test:ci`). Maintain just one `test` script, and migrate all usage of `test:ci` to using `test`. BUG: NONE
Fix lint error in app component, which was not catched before.
Add `type: module` key to package.json. Change all configuration files using commonJS syntax to have .cjs filetype.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 53.77% 61.79% +8.02%
==========================================
Files 21 25 +4
Lines 318 479 +161
Branches 30 51 +21
==========================================
+ Hits 171 296 +125
- Misses 144 180 +36
Partials 3 3 ☔ View full report in Codecov by Sentry. |
andy920262
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.