Fix post merge conflicts bug.

GoogleChromeLabs · Dec 2, 2024 · 129e0fb · 129e0fb
1 parent 4a0b73d
commit 129e0fb
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/packages/explorable-explanations/src/modules/auctions.js b/packages/explorable-explanations/src/modules/auctions.js
@@ -486,7 +486,7 @@ auction.draw = (index) => {
           const x = props.x();
           const y = props.y();
 
-          if (window.cancelPromise) {
+          if (app.cancelPromise) {
             return;
           }
           // eslint-disable-next-line no-await-in-loop
@@ -501,7 +501,7 @@ auction.draw = (index) => {
         callBack(returnValue);
       }
       if (!app.isRevisitingNodeInInteractiveMode) {
-        if (window.cancelPromise) {
+        if (app.cancelPromise) {
           return;
         }
         await utils.delay(delay); // eslint-disable-line no-await-in-loop

diff --git a/packages/explorable-explanations/src/modules/bubbles.js b/packages/explorable-explanations/src/modules/bubbles.js
@@ -140,7 +140,7 @@ bubbles.barrageAnimation = async (index) => {
       utils.wipeAndRecreateInterestCanvas();
 
       for (let i = 0; i < positionsOfCircles.length; i++) {
-        if (window.cancelPromise) {
+        if (app.cancelPromise) {
           resolve();
           return;
         }
@@ -175,7 +175,8 @@ bubbles.barrageAnimation = async (index) => {
             y > topOfBox &&
             y < topOfBox + height
           );
-        })
+        }) ||
+        app.cancelPromise
       ) {
         resolve();
       } else {
@@ -277,7 +278,7 @@ bubbles.reverseBarrageAnimation = async (index) => {
       utils.wipeAndRecreateInterestCanvas();
 
       for (let i = 0; i < positionsOfCircles.length; i++) {
-        if (window.cancelPromise) {
+        if (app.cancelPromise) {
           resolve();
           return;
         }
@@ -309,7 +310,8 @@ bubbles.reverseBarrageAnimation = async (index) => {
             Math.abs(circle.y - circle.target.y) <
               app.bubbles.minifiedCircleDiameter / 2
           );
-        })
+        }) ||
+        app.cancelPromise
       ) {
         resolve();
         document.getElementById('interest-canvas').style.zIndex = 2;