Feature: Introduce new explorable-explanations package and create reusable components #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohdsayed
changed the title
…l into ee-pa/single-seller
amovar18
pushed a commit
that referenced
this pull request
Dec 12, 2024
…sable components (#866) * Add checkbox for multi-seller * Refactor: Create box component * Create Box and ProgressLine components * Add branches component * Make Branches component return coordinates of each branch * Reset variables inside branches * Add expand icon * Position expand icon * Prevent re-rendering of text and icon * Improve ProgressLine component to accept only the starting point * Add steps for single auction flow * Improve progressline component to recieve dynamic coordinates * Add first flow for the auction * Add runAdAuction * Add more steps for single seller auction * Create an empty explorable-explanations package * Setup webpack for ee and copy code from ee directory to the new package * Get rid of ee directory * Export components * Remove auction after it's done * Add adunit-code * Update join interest groups * Update text for joinInterest group * Create utility function under flow for clearning canvas * Fix branch spacing * Fix left over arrow mark * Use loop to add more boxes for auction * Use separate state for joinInterestGroup * Add delay after one flow is complete * Code improvements and add js doc * Improve flow code and add docs * Move ripple-effect and utils to lib * Add jsdoc for timeline * Fix auction * Remove unused depencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new package, @google-psat/explorable-explanations, which provides reusable components designed to support various auction scenarios and the joinInterestGroup flows. While this PR includes initial assembly of some components for auction-related functionality, it does not implement the complete flow. Separate PRs will address the single-seller and multi-seller flows in detail.
Relevant Technical Choices
Testing Instructions
Use
npm i && npm run dev:ee:pafrom root directory.Additional Information:
Screenshot/Screencast
Checklist
[ ] This code is covered by unit tests to verify that it works as intended.[ ] The QA of this PR is done by a member of the QA team (to be checked by QA).Partially addresses #857