Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PA EE code refactoring and small fixes #893

Merged
merged 10 commits into from
Dec 16, 2024
Merged

PA EE code refactoring and small fixes #893

merged 10 commits into from
Dec 16, 2024

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Dec 13, 2024

Description

  • Change background to white and fix circle override
  • Change circle color to visited green after visit
  • Show info info to only boxes with info
  • Fix arrows not taking colors.
  • Use smooth() for main canvas
  • Create separate functions for setting up ad auction, ssp flow, branches and ad unit code

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed added this to the v1.0 milestone Dec 13, 2024
@mohdsayed mohdsayed marked this pull request as ready for review December 13, 2024 08:24
Copy link
Collaborator

@amovar18 amovar18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mohdsayed mohdsayed merged commit 6fc2ada into develop Dec 16, 2024
6 checks passed
@mohdsayed mohdsayed deleted the pa-ee-code-ref branch December 16, 2024 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants