Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add multi-seller auction #910

Merged
merged 35 commits into from
Jan 14, 2025
Merged

Feature: Add multi-seller auction #910

merged 35 commits into from
Jan 14, 2025

Conversation

mohdsayed
Copy link
Collaborator

@mohdsayed mohdsayed commented Jan 8, 2025

Description

This PR adds multi-seller auction flow when the new "Multi seller" checkbox is checked.

Relevant Technical Choices

  1. Refactor code to break it down into multiple files and folder as the code for steps was growing very large.
  2. Introduce new Text and Custom components to handle new requirements for the multi-seller.
  3. Add all steps for component auction.

Testing Instructions

  1. Open Protected Audience > Explorable Explanations tab.
  2. Click on the newly added "Multi Seller" checkbox.
  3. Observer the auction for publisher pub1.com and pub2.com, they should now show multi-seller auction

Additional Information:

I found out that the spacing in the auction changes when the speed changes. It requires some debugging and will be fixed in the next PR.

Screenshot/Screencast

image


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mohdsayed mohdsayed added this to the v1.0 milestone Jan 14, 2025
@mohdsayed mohdsayed changed the title Feat: Add multi-seller auction Feature: Add multi-seller auction Jan 14, 2025
@mohdsayed mohdsayed self-assigned this Jan 14, 2025
@mohdsayed mohdsayed marked this pull request as ready for review January 14, 2025 06:16
@mohdsayed mohdsayed requested a review from mayan-000 January 14, 2025 06:18
@mohdsayed mohdsayed merged commit 2389bb5 into develop Jan 14, 2025
6 checks passed
@mohdsayed mohdsayed deleted the feat/multi-seller branch January 14, 2025 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants