Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: EE PA Bugs #916

Merged
merged 28 commits into from
Jan 20, 2025
Merged

Fix: EE PA Bugs #916

merged 28 commits into from
Jan 20, 2025

Conversation

amovar18
Copy link
Collaborator

@amovar18 amovar18 commented Jan 17, 2025

Description

This PR fixes some regressions listed below.

Relevant Technical Choices

Testing Instructions

  • Clone this branch.
  • In the terminal run npm i && npm run build:ext.
  • Now in the browser, open DevTools and then open PSAT.
  • Now navigate to the protected audience and run the Explorable Explanation, The following issues listed in the additional information should be fixed.

Additional Information:

  • Regression: Expand button doesn’t work in Interactive Mode.
  • Clicking on the ad-container in the Ad Units section, also highlights the inspect button in Cookies.
  • Ad Unit Code and Ad Container Size in Bids tab in the bottom table shouldn’t be empty.
  • Interest group data should be in sync with the IG bubble, currently the table data stays even when we hit the reset button and the IG bubble becomes empty.
  • When animation is paused, user click on expanding bubbles after closing the bubble, animation restarts automatically
  • Interest groups should be persistent in the interest group tab.
  • Auto tab switch to IG table from auction table in EE not happening after visit from publisher to advertiser
  • At certain instances when user reaches adv6.com and the reset button is pressed before animation completion, the IG table is not cleared properly, adv6 IG are still visible
  • Issue is when bubbles are travelling, and we click reset the data in table doesn't reset completely
  • Reset button does stop the queue, but the bubble's travelling callback which was popped and was running doesn't end. It completes its execution, because of this the data remains in the table
  • Inconsistent data on going back to animation
  • When in interactive mode when the auto expand is unchecked.
    • When I expand a completed node the user icon disappear from cursor.
    • When click on next node, it expanded the previous node
    • When user icon disappear from cursor, it appears from corner of bubble, but when we hover on completed node it disappears.

Screenshot/Screencast


Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes #857

@amovar18 amovar18 self-assigned this Jan 17, 2025
@amovar18 amovar18 requested review from mohdsayed and mayan-000 and removed request for mayan-000 January 17, 2025 06:57
@amovar18 amovar18 marked this pull request as ready for review January 17, 2025 06:57
@amovar18 amovar18 added this to the v1.0 milestone Jan 17, 2025
@mayan-000 mayan-000 self-assigned this Jan 17, 2025
@mohdsayed
Copy link
Collaborator

Let's do this one separately

[ ] Ad Unit Code and Ad Container Size in Bids tab in the bottom table shouldn’t be empty.

@mohdsayed mohdsayed merged commit 98e8c62 into develop Jan 20, 2025
6 checks passed
@mohdsayed mohdsayed deleted the fix/ee-bugs branch January 20, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants