Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Autoscroll table on row highlighting #919

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

mayan-000
Copy link
Collaborator

@mayan-000 mayan-000 commented Jan 23, 2025

Description

This PR adds code for the autoscrolling table to the highlighted row.

  • When an IG bubble is clicked, the related row to that IG will be highlighted, and if the row is outside the screen preview, the table auto-scrolls to the required row.
    • This is not limited to the IG table, the changes are inside the table's body row, so if any table has enabled highlighting, this logic should work.
  • Alongside this PR also updates the comparison logic for highlighting by comparing the owner of the IG.

Relevant Technical Choices

Testing Instructions

Additional Information:

Screenshot/Screencast

Screen.Recording.2025-01-23.at.17.37.55.mov

Checklist

  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Partially addresses #857

@mayan-000 mayan-000 self-assigned this Jan 23, 2025
@mayan-000 mayan-000 marked this pull request as ready for review January 24, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant