FreeQueue + WASM example #255
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DivyamAhuja
commented
Sep 6, 2022
DivyamAhuja
commented
Sep 6, 2022
hoch
reviewed
Sep 6, 2022
src/audio-worklet/free-queue/examples/hello-webassembly/build/example.worker.js
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c
Outdated
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js
Outdated
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js
Outdated
Show resolved
Hide resolved
hoch
reviewed
Sep 13, 2022
src/audio-worklet/free-queue/examples/hello-webassembly/README.md
Outdated
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c
Outdated
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/example.c
Outdated
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js
Outdated
Show resolved
Hide resolved
|
|
||
| // Pull out render quantum frame from the queue into output. | ||
| // If failed, print "failed" to console. | ||
| const didPull = this.queue.pull(output, RENDER_QUANTUM); |
There was a problem hiding this comment.
Perhaps:
return this.queue.pull(output, RENDER_QUANTUM) ? true : false;
There was a problem hiding this comment.
I don't think we can return false here.
Then I think audio worklet will just stop 🤔
https://webaudio.github.io/web-audio-api/#callback-audioworketprocess-callback
So I think we should always return true, to keep worklet alive
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js
Outdated
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js
Outdated
Show resolved
Hide resolved
src/audio-worklet/free-queue/examples/hello-webassembly/sink-processor.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So here it is!
WebAssembly Example
Hello WebAssembly Example
It takes some time for audio to start, cause of silence in start of audio