Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add UUID support in import/export templates #2145

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lagarwal1
Copy link

feat: Add support for importing/exporting UUID columns as strings

Tests in cloud devel

Avro

GSQL

Export
Import

Postgres

Export
Import

CSV

GSQL

Export - Todo
Import - Todo

Postgres

Export - Todo
Import - Todo

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 57.81250% with 27 lines in your changes missing coverage. Please review.

Project coverage is 46.83%. Comparing base (177a218) to head (4a03adc).
Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
...e/beam/it/gcp/spanner/matchers/SpannerAsserts.java 0.00% 13 Missing ⚠️
...cloud/teleport/spanner/SpannerRecordConverter.java 33.33% 4 Missing and 2 partials ⚠️
...le/cloud/teleport/spanner/TextImportTransform.java 0.00% 2 Missing and 2 partials ⚠️
.../apache/beam/sdk/io/gcp/spanner/SpannerSchema.java 0.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2145      +/-   ##
============================================
+ Coverage     46.40%   46.83%   +0.43%     
- Complexity     3932     4324     +392     
============================================
  Files           859      874      +15     
  Lines         51300    52008     +708     
  Branches       5394     5458      +64     
============================================
+ Hits          23804    24359     +555     
- Misses        25783    25909     +126     
- Partials       1713     1740      +27     
Components Coverage Δ
spanner-templates 68.79% <77.27%> (+0.53%) ⬆️
spanner-import-export 65.63% <77.27%> (+0.03%) ⬆️
spanner-live-forward-migration 76.50% <ø> (-0.17%) ⬇️
spanner-live-reverse-replication 78.66% <ø> (+0.72%) ⬆️
spanner-bulk-migration 87.87% <ø> (+0.57%) ⬆️
Files with missing lines Coverage Δ
...le/cloud/teleport/spanner/AvroRecordConverter.java 99.69% <ø> (ø)
...oud/teleport/spanner/AvroSchemaToDdlConverter.java 84.88% <100.00%> (+1.32%) ⬆️
...teleport/spanner/BuildReadFromTableOperations.java 44.92% <100.00%> (+9.33%) ⬆️
...oud/teleport/spanner/DdlToAvroSchemaConverter.java 93.03% <ø> (ø)
...gle/cloud/teleport/spanner/TextImportPipeline.java 0.00% <ø> (ø)
...oogle/cloud/teleport/spanner/common/SizedType.java 91.97% <100.00%> (+0.26%) ⬆️
...com/google/cloud/teleport/spanner/common/Type.java 90.62% <100.00%> (+0.43%) ⬆️
.../com/google/cloud/teleport/spanner/ddl/Column.java 83.78% <100.00%> (+0.60%) ⬆️
...google/cloud/teleport/templates/TextToSpanner.java 23.43% <100.00%> (+0.40%) ⬆️
...le/cloud/teleport/spanner/TextImportTransform.java 43.47% <0.00%> (-0.59%) ⬇️
... and 3 more

... and 55 files with indirect coverage changes

@lagarwal1 lagarwal1 changed the title Add UUID support in import/export templates [WIP] Add UUID support in import/export templates Jan 23, 2025
@lagarwal1 lagarwal1 marked this pull request as draft January 23, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants