Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: account for on-premise Neo4j CalVer version format #2149

Merged

Conversation

fbiville
Copy link
Collaborator

No description provided.

Copy link
Contributor

@ali-ince ali-ince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.86%. Comparing base (7a4ebad) to head (bde9cde).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2149   +/-   ##
=========================================
  Coverage     46.86%   46.86%           
  Complexity     4006     4006           
=========================================
  Files           874      874           
  Lines         52026    52030    +4     
  Branches       5451     5452    +1     
=========================================
+ Hits          24380    24386    +6     
+ Misses        25904    25901    -3     
- Partials       1742     1743    +1     
Components Coverage Δ
spanner-templates 68.77% <ø> (-0.01%) ⬇️
spanner-import-export 65.56% <ø> (-0.02%) ⬇️
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.66% <ø> (ø)
spanner-bulk-migration 87.87% <ø> (ø)
Files with missing lines Coverage Δ
.../teleport/v2/neo4j/database/Neo4jCapabilities.java 81.81% <100.00%> (+0.99%) ⬆️

... and 2 files with indirect coverage changes

@liferoad liferoad merged commit e6a515b into GoogleCloudPlatform:main Jan 25, 2025
15 of 16 checks passed
@fbiville fbiville deleted the neo4j/version_parsing_update branch January 27, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants