Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Infra] Do not generate shaded jar for common modules #2157

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Abacn
Copy link
Contributor

@Abacn Abacn commented Jan 29, 2025

Fix #2158

skipped shaded jar for common modules that do not contain any @Template

@Abacn Abacn changed the title Do not generate shaded jar for common modules [Infra] Do not generate shaded jar for common modules Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.89%. Comparing base (208e2ba) to head (ebb3a55).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##               main    #2157    +/-   ##
==========================================
  Coverage     46.88%   46.89%            
- Complexity     4014     4345   +331     
==========================================
  Files           874      874            
  Lines         52042    52070    +28     
  Branches       5454     5461     +7     
==========================================
+ Hits          24402    24419    +17     
- Misses        25901    25906     +5     
- Partials       1739     1745     +6     
Components Coverage Δ
spanner-templates 68.80% <ø> (-0.02%) ⬇️
spanner-import-export 65.63% <ø> (-0.04%) ⬇️
spanner-live-forward-migration 76.50% <ø> (ø)
spanner-live-reverse-replication 78.67% <ø> (ø)
spanner-bulk-migration 87.87% <ø> (ø)

see 3 files with indirect coverage changes

@Abacn Abacn force-pushed the skipshade branch 2 times, most recently from d8162f7 to bd0942b Compare January 29, 2025 23:31
@Abacn
Copy link
Contributor Author

Abacn commented Jan 29, 2025

I believe this would largely improve the log spam of release workflow log. Current log for Release workflow is 120 MB and almost half are these logs / another half being #1800

@Abacn Abacn marked this pull request as ready for review January 30, 2025 03:37
@Abacn Abacn requested review from a team as code owners January 30, 2025 03:37
@Abacn
Copy link
Contributor Author

Abacn commented Jan 30, 2025

SpannerChangeStreamsToGcsIT.testSpannerChangeStreamsToGcsAvro[Default]

Caused by: com.google.cloud.spanner.SpannerException: FAILED_PRECONDITION: Operation with name "projects/cloud-teleport-testing/instances/teleport/databases/testspa_20250130_023955_qsbwrw/operations/r2f63ae85_0ee6_422b_ba6e_23130c0b4480" failed with status = GrpcStatusCode{transportCode=FAILED_PRECONDITION} and message = Duplicate name in schema: testSpannerChangeStreamsToGcsAvroDefault.

is a flaky test, not related to this change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Release workflow log spam maven-shaded-plugin warning: define ... overlapping classes
3 participants