-
Notifications
You must be signed in to change notification settings - Fork 988
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Infra] Do not generate shaded jar for common modules #2157
Open
Abacn
wants to merge
1
commit into
GoogleCloudPlatform:main
Choose a base branch
from
Abacn:skipshade
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2157 +/- ##
==========================================
Coverage 46.88% 46.89%
- Complexity 4014 4345 +331
==========================================
Files 874 874
Lines 52042 52070 +28
Branches 5454 5461 +7
==========================================
+ Hits 24402 24419 +17
- Misses 25901 25906 +5
- Partials 1739 1745 +6
|
d8162f7
to
bd0942b
Compare
I believe this would largely improve the log spam of release workflow log. Current log for Release workflow is 120 MB and almost half are these logs / another half being #1800 |
is a flaky test, not related to this change |
darshan-sj
approved these changes
Feb 4, 2025
georgecma
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2158
skipped shaded jar for common modules that do not contain any
@Template