Bug/google sheets series #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kmaphoenix ready to merge. You can delete the PR #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
While I was reviewing and testing the below bug, I noticed a couple of more bugs.
#140
Even though, CopyUtil class passes an agent id to Flows class, we are still seeing an error when executing cu.flows.get_flows_map(reverse=True) because
In flows.get_flows_map function, there is no condition that sets an agent_id = self.agent_id if not agent_id
List of the changes:
I added the condition that sets an agent_id = self.agent_id if not agent_id in Flows.get_flows_map and Flows.list_flows
Because of df.append, we are seeing an error "FutureWarning: The frame.append method is deprecated and will be removed from pandas in a future version. Use pandas.concat instead.".
Instead of df.append, Milad suggested changing to cu.intents.bulk_intent_to_df(intent_subset=intent_list_names)
OLD:
print('Total # of Intents = {}'.format(df.intent.nunique()))
print('Total # of Training Phrases = {}'.format(df.tp.nunique()))
NEW:
print('Total # of Intents = {}'.format(df.display_name.nunique()))
print('Total # of Training Phrases = {}'.format(df.training_phrase.nunique()))