Skip to content

Commit

Permalink
feat: use gae-runtimes GCR for builders (#117)
Browse files Browse the repository at this point in the history
* feat: use gae-runtimes GCR for builders

This includes the ability to use the latest tag to always test with the
latest builder.
  • Loading branch information
anniefu authored Nov 4, 2022
1 parent 42e1d91 commit 1975792
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
3 changes: 1 addition & 2 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,5 +39,4 @@ jobs:
-validate-mapping=false \
-builder-source='testdata' \
-builder-target='HTTP' \
-builder-runtime='go113' \
-builder-tag='go113_20220501_1_13_15_RC00'
-builder-runtime='go113'
4 changes: 2 additions & 2 deletions client/buildpacks.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (

const (
image = "conformance-test-func"
builderURL = "us.gcr.io/fn-img/buildpacks/%s/builder:%s"
builderURL = "gcr.io/buildpacks/builder:%s"
gcfTargetPlatform = "gcf"
)

Expand Down Expand Up @@ -82,7 +82,7 @@ func (b *buildpacksFunctionServer) OutputFile() ([]byte, error) {
}

func (b *buildpacksFunctionServer) build(ctx context.Context) error {
builder := fmt.Sprintf(builderURL, b.runtime, b.tag)
builder := fmt.Sprintf(builderURL, b.tag)

cmd := exec.Command("docker", "pull", builder)
output, err := cmd.CombinedOutput()
Expand Down

0 comments on commit 1975792

Please sign in to comment.