Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gae): delete old region tags from projectionqueries.go #5121

Conversation

OremGLG
Copy link
Contributor

@OremGLG OremGLG commented Jan 31, 2025

Description

Delete old region tags from docs/appengine/datastore/projectionqueries/projectionqueries.go following the PRs #5108 and #5119

Fixes
b/392146363
b/392145933
b/392146306
b/391185644
b/391186679

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Contributing Guidelines from CONTRIBUTING.MD
  • Tests pass: go test -v ./.. (see Testing)
  • Code formatted: gofmt (see Formatting)
  • Vetting pass: go vet (see Formatting)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 31, 2025
Copy link

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by OremGLG, aims to clean up the projectionqueries.go file in the Google App Engine Datastore samples by removing outdated region tags. The changes are purely cosmetic and do not affect the functionality of the code.

Here's a breakdown of the changes:

  • File Modified: docs/appengine/datastore/projectionqueries/projectionqueries.go
  • Changes: The PR removes several instances of old region tags (e.g., // [START using_1], // [END using_1]). These tags were likely used for documentation purposes but are no longer needed. The removal simplifies the code and improves readability.
    • Lines 32-34 were modified to remove // [START using_1] and // [END using_1].
    • Lines 41-41 were modified to remove // [START using_2] and // [END using_2].
    • Lines 64-69 were modified to remove // [START grouping] and // [END grouping].
    • Lines 79-81 were modified to remove // [START projections_and_multiple_valued_properties_1] and // [END projections_and_multiple_valued_properties_1].
    • Lines 88-90 were modified to remove // [START projections_and_multiple_valued_properties_2] and // [END projections_and_multiple_valued_properties_2].
  • Intent: To improve code cleanliness and maintainability by removing obsolete region tags.
  • Associated Issues: The PR description links to several Google internal bug reports (b/392146363, b/392145933, b/392146306, b/391185644, b/391186679) suggesting this cleanup is part of a larger effort.

The author has indicated that the tests, code formatting, and vetting have passed.


A little haiku to brighten your day:

Old tags now removed,
Code shines, clean and bright anew,
Review's quick and fun.

@OremGLG OremGLG marked this pull request as ready for review January 31, 2025 19:57
@OremGLG OremGLG requested review from a team as code owners January 31, 2025 19:57
Copy link

snippet-bot bot commented Jan 31, 2025

Here is the summary of changes.

You are about to delete 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@telpirion telpirion self-assigned this Feb 4, 2025
@telpirion telpirion enabled auto-merge (squash) February 4, 2025 16:36
@telpirion telpirion merged commit 49c4f65 into GoogleCloudPlatform:main Feb 4, 2025
9 checks passed
@OremGLG OremGLG deleted the garciadiaz-chore-delete-old-region-projection-queries branch February 4, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants