Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ftr logging link alpha #3181

Open
wants to merge 41 commits into
base: master
Choose a base branch
from
Open

Ftr logging link alpha #3181

wants to merge 41 commits into from

Conversation

tylerreidwaze
Copy link
Collaborator

@tylerreidwaze tylerreidwaze commented Nov 14, 2024

Change description

This PR adds LoggingLinks as a KCC Resource

Tests you have done

  • Run make ready-pr to ensure this PR is ready for review.
  • Perform necessary E2E testing for changed resources.

Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tylerreidwaze tylerreidwaze changed the title Ftr logging link alpha do-not-merge/work-in-progress - Ftr logging link alpha Nov 15, 2024
apis/logging/v1alpha1/link_types.go Outdated Show resolved Hide resolved
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no need to write this file anymore. apis/logging/v1alpha1/link_reference.go is autogenerated, where ResolveLoggingLogBucketRef equals to NormalizedExternal

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to update the pkg/clients/generated any more (I'm curious, is there any doc asking you to do so?). They are the legacy way to generate the go client lib. With the direct approach, we uses the sig-kubernetes controller-gen and the apis/logging is enough. Here's the announcement if you are interested https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/pkg/clients/generated/README.md

@tylerreidwaze tylerreidwaze force-pushed the ftr-logging-link-alpha branch from 1b8855d to 752fc03 Compare February 6, 2025 22:53
@tylerreidwaze tylerreidwaze changed the title do-not-merge/work-in-progress - Ftr logging link alpha Ftr logging link alpha Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants