-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr logging link alpha #3181
base: master
Are you sure you want to change the base?
Ftr logging link alpha #3181
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
apis/refs/v1beta1/logbucketref.go
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, no need to write this file anymore. apis/logging/v1alpha1/link_reference.go
is autogenerated, where ResolveLoggingLogBucketRef
equals to NormalizedExternal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to update the pkg/clients/generated
any more (I'm curious, is there any doc asking you to do so?). They are the legacy way to generate the go client lib. With the direct approach, we uses the sig-kubernetes controller-gen and the apis/logging
is enough. Here's the announcement if you are interested https://github.com/GoogleCloudPlatform/k8s-config-connector/blob/master/pkg/clients/generated/README.md
…hat the mapper is doing
1b8855d
to
752fc03
Compare
Change description
This PR adds LoggingLinks as a KCC Resource
Tests you have done
make ready-pr
to ensure this PR is ready for review.