Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conductor: fixes for cmd=12, mock service and resource gen #3926

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

barney-s
Copy link
Collaborator

@barney-s barney-s commented Mar 9, 2025

  • Fix paths for cmd 12
  • Fix special case where resource is named service (metastore-service) and the generated resource file (service.go) clashes with another generated file service.go.
  • add cmd=7 diff last N commits across all branches

Verified:

❯ time ./bin/conductor runner --branch-repo=/usr/local/google/home/barni/workspace/src/github.com/barney-s/vertex-notebook/k8s-config-connector  --branch-conf=branches-barni.yaml --logging-dir=logs  --command=12
2025/03/08 20:39:50 Running conductor runner with branch config: branches-barni.yaml
2025/03/08 20:39:50 Starting Runner
2025/03/08 20:39:50 Generate mock Service and Resource go files: 0 name: api-quotapreference, branch: resource-api-quotapreference
2025/03/08 20:39:50 Logging dir: logs/api-quotapreference
2025/03/08 20:39:50 Generate mock Service and Resource go files: 1 name: api-quotaadjustersettings, branch: resource-api-quotaadjustersettings
2025/03/08 20:39:50 Logging dir: logs/api-quotaadjustersettings
2025/03/08 20:40:29 Generate mock Service and Resource go files: 2 name: asset-feed, branch: resource-asset-feed
2025/03/08 20:40:29 Logging dir: logs/asset-feed
2025/03/08 20:40:55 Generate mock Service and Resource go files: 3 name: asset-savedquery, branch: resource-asset-savedquery
2025/03/08 20:40:55 Logging dir: logs/asset-savedquery
2025/03/08 20:41:28 Generate mock Service and Resource go files: 4 name: datacatalog-entry, branch: resource-datacatalog-entry
2025/03/08 20:41:28 Logging dir: logs/datacatalog-entry
2025/03/08 20:41:57 Generate mock Service and Resource go files: 5 name: datacatalog-entrygroup, branch: resource-datacatalog-entrygroup
2025/03/08 20:41:57 Logging dir: logs/datacatalog-entrygroup
2025/03/08 20:42:40 Generate mock Service and Resource go files: 6 name: datacatalog-tag, branch: resource-datacatalog-tag
2025/03/08 20:42:40 Logging dir: logs/datacatalog-tag
2025/03/08 20:43:09 Generate mock Service and Resource go files: 7 name: datacatalog-tagtemplate, branch: resource-datacatalog-tagtemplate
2025/03/08 20:43:09 Logging dir: logs/datacatalog-tagtemplate
2025/03/08 20:43:37 Generate mock Service and Resource go files: 8 name: essentialcontacts-contact, branch: resource-essentialcontacts-contact
2025/03/08 20:43:37 Logging dir: logs/essentialcontacts-contact
2025/03/08 20:44:05 Generate mock Service and Resource go files: 9 name: eventarc-channel, branch: resource-eventarc-channel
2025/03/08 20:44:05 Logging dir: logs/eventarc-channel
2025/03/08 20:45:02 Generate mock Service and Resource go files: 10 name: eventarc-googlechannelconfig, branch: resource-eventarc-googlechannelconfig
2025/03/08 20:45:02 Logging dir: logs/eventarc-googlechannelconfig
2025/03/08 20:45:31 Generate mock Service and Resource go files: 11 name: metastore-service, branch: resource-metastore-service
2025/03/08 20:45:31 Logging dir: logs/metastore-service
2025/03/08 20:45:56 Generate mock Service and Resource go files: 12 name: metastore-backup, branch: resource-metastore-backup
2025/03/08 20:45:56 Logging dir: logs/metastore-backup
2025/03/08 20:46:24 Generate mock Service and Resource go files: 13 name: metastore-federation, branch: resource-metastore-federation
2025/03/08 20:46:24 Logging dir: logs/metastore-federation
./bin/conductor runner  --branch-conf=branches-barni.yaml --logging-dir=logs   62.96s user 40.32s system 24% cpu 7:07.19 total

@barney-s barney-s requested a review from cheftako March 9, 2025 01:53
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from barney-s. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@barney-s barney-s requested a review from justinsb March 9, 2025 01:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant