Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Gemini Data Sharing With Google Setting resource #12905

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PerlMonker303
Copy link
Contributor

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Add new resources for Gemini Admin Control

`google_gemini_data_sharing_with_google_setting`

Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SirGitsalot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 29, 2025
@modular-magician modular-magician added service/gemini and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 29, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 6 files changed, 808 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 7 files changed, 978 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_data_sharing_with_google_setting (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_data_sharing_with_google_setting" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 8
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • gemini

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccGeminiDataSharingWithGoogleSetting_geminiDataSharingWithGoogleSettingBasicExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccGeminiDataSharingWithGoogleSetting_geminiDataSharingWithGoogleSettingBasicExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🟢 All tests passed!

View the build log or the debug log for each test

@PerlMonker303
Copy link
Contributor Author

@SirGitsalot Let me know if there is anything else I'm missing here.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 143 insertions(+))
google-beta provider: Diff ( 7 files changed, 981 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 86 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_gemini_data_sharing_with_google_setting (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_gemini_data_sharing_with_google_setting" "primary" {
  labels = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 11
Passed tests: 11
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • gemini

🟢 All tests passed!

View the build log

Copy link

github-actions bot commented Feb 3, 2025

@SirGitsalot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants