Add Jetstream dashboard and hidden integration #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EvanSimpson
reviewed
Feb 4, 2025
| display_name: Jetstream Prometheus Overview | ||
| description: "This dashboard has charts displaying request rate, latency, queue sizes and other metrics for Jetstream inference." | ||
| related_integrations: | ||
| - id: jetstream |
There was a problem hiding this comment.
FYI dashboard and integration will deploy separately
There was a problem hiding this comment.
Ack. I don't think it's a big deal because:
- the integration is being added as HIDDEN -- I'll wait for both to propagate fully, validate it internally and publish the corresponding docs before we mark it as GA
- I believe our FE code fails gracefully if either deploys before the other
| @@ -0,0 +1,1004 @@ | |||
| { | |||
| "displayName": "JetStream Prometheus Overview", | |||
There was a problem hiding this comment.
This is the only place the s in JetStream is capitalized, should this + images be updated, or yaml files?
There was a problem hiding this comment.
Good catch! Based on:
- https://cloud.google.com/kubernetes-engine/docs/tutorials/serve-gemma-tpu-jetstream
- https://github.com/AI-Hypercomputer/JetStream
It looks like "JetStream" is right, so I've fixed everything else to match.
EvanSimpson
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed at go/jetstream-dashboard-dev-notes. We'll validate this internally before setting the integration status from HIDDEN to GA.