Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update actions/checkout action to v4 (non-fork) #3560

Merged
merged 8 commits into from
Nov 10, 2023

Conversation

glasnt
Copy link
Contributor

@glasnt glasnt commented Nov 1, 2023

Description

Replaces #3546, replicating changes on a branch rather than a fork.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Nov 1, 2023
@glasnt glasnt marked this pull request as ready for review November 1, 2023 02:53
@glasnt glasnt requested review from a team as code owners November 1, 2023 02:53
@rogerthatdev
Copy link
Contributor

the functions-slack test has consistently been failing and currently blocking submitting this PR.

@glasnt Would you remove the change to .github/workflows/functions-slack.yaml from this PR and put it in another one?

Copy link
Contributor

@rogerthatdev rogerthatdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass, LGTM!

@glasnt glasnt merged commit 19094b0 into main Nov 10, 2023
17 checks passed
@glasnt glasnt deleted the renovate-3546 branch November 10, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run api: workflows Issues related to the Workflows API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants