-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(texttospeech): modernize quickstart for texttospeech #3726
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found no blockers, but left several comments with opportunities for additional minor improvements. Offering them because I see the scope as "modernizing" the quickstart, which leaves the scope ambiguously larger than the referenced issue.
05457b5
to
2a8560d
Compare
103660e
to
be61da8
Compare
be61da8
to
58b1c3d
Compare
@iennae / @grayside I went ahead and did a bunch of refactoring (feel free to undo with a |
Description
Fixes #3504
(draft, still requires test update, region tags not added yet intentionally)
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.