Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update d-e workflows for labeled on pull_request trigger #3755

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Conversation

grayside
Copy link
Collaborator

Description

Implementation of #3747, sibling of #3748.

Scoped to Samples workflows with file names starting with d-e, like: datastore, dialogflow, discoveryengine, document-ai, document-warehouse, endpoints, error-reporting, & eventarc.

This batch is by github workflow filename.

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@grayside grayside self-assigned this Jul 24, 2024
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: workflows Issues related to the Workflows API. labels Jul 24, 2024
@grayside grayside added actions:force-run and removed api: workflows Issues related to the Workflows API. labels Jul 24, 2024
@grayside grayside marked this pull request as ready for review July 24, 2024 17:09
@grayside grayside requested review from a team as code owners July 24, 2024 17:09
@grayside
Copy link
Collaborator Author

Test failure seems unrelated.

@subfuzion
Copy link
Contributor

Test failure seems unrelated.

Concur, opened b/355236484 for following up separately.

@iennae iennae merged commit 917da65 into main Jul 25, 2024
50 of 51 checks passed
@iennae iennae deleted the prt-de-tests branch July 25, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions:force-run samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants