Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: compute_disk_create_secondary/regional/custom/(start/stop)replication #3917

Merged
merged 5 commits into from
Dec 5, 2024
Merged

feat: compute_disk_create_secondary/regional/custom/(start/stop)replication #3917

merged 5 commits into from
Dec 5, 2024

Conversation

gryczj
Copy link
Contributor

@gryczj gryczj commented Nov 5, 2024 •
edited
Loading

Description

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@gryczj gryczj requested review from a team as code owners November 5, 2024 11:45
@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: compute Issues related to the Compute Engine API. labels Nov 5, 2024
@snippet-bot Snippet Bot
Copy link

snippet-bot bot commented Nov 5, 2024 •
edited
Loading

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@gryczj gryczj force-pushed the compute_disk_create_secondary branch from 23104ba to 2de0774 Compare November 5, 2024 11:46
@gryczj gryczj added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Nov 5, 2024
@gryczj gryczj force-pushed the compute_disk_create_secondary branch 2 times, most recently from 3614783 to 6d74034 Compare November 5, 2024 12:46
@gryczj gryczj changed the title feat: compute_disk_create_secondary feat: compute_disk_create_secondary/regional Nov 5, 2024
@gryczj gryczj force-pushed the compute_disk_create_secondary branch from 6d74034 to 41446fc Compare November 5, 2024 13:50
@gryczj gryczj changed the title feat: compute_disk_create_secondary/regional feat: compute_disk_create_secondary/regional/custom Nov 6, 2024
@gryczj gryczj changed the title feat: compute_disk_create_secondary/regional/custom feat: compute_disk_create_secondary/regional/custom/(start/stop)replication Nov 6, 2024
@gryczj gryczj force-pushed the compute_disk_create_secondary branch from 66cdce0 to cff6a55 Compare November 12, 2024 15:11
@gryczj gryczj force-pushed the compute_disk_create_secondary branch 2 times, most recently from 40cd278 to ee8997f Compare November 26, 2024 12:24
@gryczj gryczj force-pushed the compute_disk_create_secondary branch from ee8997f to 4a7c333 Compare December 3, 2024 11:42
m-strzelczyk
m-strzelczyk approved these changes Dec 3, 2024
View reviewed changes
compute/disks/createCustomSecondaryDisk.js Outdated
Comment on lines 79 to 87
// Specify additional guest OS features.
// You don't need to include the guest OS features of the primary disk.
// The secondary disk automatically inherits the guest OS features of the primary disk.
guestOsFeatures: [
new compute.GuestOsFeature({
type: 'NEW_FEATURE_ID_1',
}),
],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a link to a page where those features are listed and described.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@m-strzelczyk link to documentation added

@gryczj gryczj force-pushed the compute_disk_create_secondary branch from 4a7c333 to f5f1f62 Compare December 3, 2024 17:11
@gryczj gryczj requested a review from m-strzelczyk December 3, 2024 17:11
@gryczj gryczj force-pushed the compute_disk_create_secondary branch from f5f1f62 to ded92ee Compare December 4, 2024 13:53
@BigBlackWolf BigBlackWolf self-requested a review December 5, 2024 11:55
@iennae iennae merged commit 697100d into main Dec 5, 2024
133 of 134 checks passed
@iennae iennae deleted the compute_disk_create_secondary branch December 5, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-strzelczyk m-strzelczyk Awaiting requested review from m-strzelczyk

@BigBlackWolf BigBlackWolf Awaiting requested review from BigBlackWolf

Assignees
No one assigned
Labels
api: compute Issues related to the Compute Engine API. kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gryczj @m-strzelczyk @iennae