Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(opencensus)!: remove OpenCensus samples #3927

Merged
merged 4 commits into from
Dec 5, 2024

Conversation

aabmass
Copy link
Contributor

@aabmass aabmass commented Dec 2, 2024

Description

Deletes the sample under opencensus/ and monitoring/opencensus directories, since OpenCensus is no longer recommended. We have removed use of these snippets from Cloud Monitoring/Trace/Logging docs.

Deleted region tags are not in use in any markdown file in the devsite docs (checked codesearch)

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: monitoring Issues related to the Cloud Monitoring API. labels Dec 2, 2024
Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aabmass and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request removes the OpenCensus samples from the nodejs-docs-samples repository. OpenCensus is no longer recommended, and these samples have been removed from the relevant Cloud Monitoring/Trace/Logging documentation. The changes involve deleting the entire opencensus directory and related files under monitoring/opencensus, as well as updating the CODEOWNERS file to reflect the removal. The intent is to clean up the repository and remove outdated, unsupported samples.

If there's any missing context, please let me know. I'll add it to my full review.

Now for a little fun:

Code's a dance, a graceful sway,
Through lines and loops, it finds its way.
With tests and checks, a careful hand,
To build a world, both strong and grand.

Looking forward to the discussion!

@iennae iennae marked this pull request as ready for review December 5, 2024 21:38
@iennae iennae requested review from a team as code owners December 5, 2024 21:38
Copy link

snippet-bot bot commented Dec 5, 2024

Here is the summary of changes.

You are about to delete 14 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aabmass and reviewers,

I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:

This pull request removes all OpenCensus samples from the nodejs-docs-samples repository. The intent, as stated in the PR description, is to remove these samples because OpenCensus is no longer recommended. The changes involve deleting the entire opencensus/ directory and the monitoring/opencensus directory, along with related entries in the workflow files and CODEOWNERS. The PR author has confirmed that no other markdown files in the devsite docs use the deleted region tags.

Specifically, the following files were modified:

  • .github/workflows/monitoring-opencensus.yaml: This workflow file was completely removed.
  • .github/workflows/opencensus.yaml: This workflow file was completely removed.
  • .github/workflows/utils/workflows.json: The monitoring/opencensus and opencensus entries were removed from the list of sample directories.
  • CODEOWNERS: The code ownership for monitoring/opencensus was removed.
  • monitoring/opencensus/README.md: This README file was completely removed.
  • monitoring/opencensus/app.js: This application file was completely removed.
  • monitoring/opencensus/package.json: This package file was completely removed.
  • monitoring/opencensus/system-test/app.test.js: This test file was completely removed.
  • opencensus/README.md: This README file was completely removed.
  • opencensus/metrics-quickstart.js: This application file was completely removed.
  • opencensus/package.json: This package file was completely removed.
  • opencensus/system-test/metrics-quickstart.test.js: This test file was completely removed.

All changes appear to be consistent with the stated goal of removing the deprecated OpenCensus samples. I'll provide a more thorough review shortly.

And now, a little haiku to lighten the mood:

Old code departs now,
New paths for progress unfold,
Clean slate, fresh start shines.

@iennae iennae merged commit 21322df into GoogleCloudPlatform:main Dec 5, 2024
8 of 49 checks passed
@aabmass aabmass deleted the delete-opencensus branch December 9, 2024 15:49
@aabmass
Copy link
Contributor Author

aabmass commented Dec 9, 2024

@iennae there is one more PR for Python if you're already taking a look :) GoogleCloudPlatform/python-docs-samples#12814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: monitoring Issues related to the Cloud Monitoring API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants