-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(opencensus)!: remove OpenCensus samples #3927
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aabmass and reviewers,
I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:
This pull request removes the OpenCensus samples from the nodejs-docs-samples
repository. OpenCensus is no longer recommended, and these samples have been removed from the relevant Cloud Monitoring/Trace/Logging documentation. The changes involve deleting the entire opencensus
directory and related files under monitoring/opencensus
, as well as updating the CODEOWNERS
file to reflect the removal. The intent is to clean up the repository and remove outdated, unsupported samples.
If there's any missing context, please let me know. I'll add it to my full review.
Now for a little fun:
Code's a dance, a graceful sway,
Through lines and loops, it finds its way.
With tests and checks, a careful hand,
To build a world, both strong and grand.
Looking forward to the discussion!
Here is the summary of changes. You are about to delete 14 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @aabmass and reviewers,
I'm currently reviewing this pull request and will post my detailed review in a few minutes. In the meantime, here's a quick summary to help everyone get up to speed:
This pull request removes all OpenCensus samples from the nodejs-docs-samples
repository. The intent, as stated in the PR description, is to remove these samples because OpenCensus is no longer recommended. The changes involve deleting the entire opencensus/
directory and the monitoring/opencensus
directory, along with related entries in the workflow files and CODEOWNERS
. The PR author has confirmed that no other markdown files in the devsite docs use the deleted region tags.
Specifically, the following files were modified:
.github/workflows/monitoring-opencensus.yaml
: This workflow file was completely removed..github/workflows/opencensus.yaml
: This workflow file was completely removed..github/workflows/utils/workflows.json
: Themonitoring/opencensus
andopencensus
entries were removed from the list of sample directories.CODEOWNERS
: The code ownership formonitoring/opencensus
was removed.monitoring/opencensus/README.md
: This README file was completely removed.monitoring/opencensus/app.js
: This application file was completely removed.monitoring/opencensus/package.json
: This package file was completely removed.monitoring/opencensus/system-test/app.test.js
: This test file was completely removed.opencensus/README.md
: This README file was completely removed.opencensus/metrics-quickstart.js
: This application file was completely removed.opencensus/package.json
: This package file was completely removed.opencensus/system-test/metrics-quickstart.test.js
: This test file was completely removed.
All changes appear to be consistent with the stated goal of removing the deprecated OpenCensus samples. I'll provide a more thorough review shortly.
And now, a little haiku to lighten the mood:
Old code departs now,
New paths for progress unfold,
Clean slate, fresh start shines.
@iennae there is one more PR for Python if you're already taking a look :) GoogleCloudPlatform/python-docs-samples#12814 |
Description
Deletes the sample under
opencensus/
andmonitoring/opencensus
directories, since OpenCensus is no longer recommended. We have removed use of these snippets from Cloud Monitoring/Trace/Logging docs.Deleted region tags are not in use in any markdown file in the devsite docs (checked codesearch)
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.