Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update blunderbuss.yml #3934

Merged
merged 1 commit into from
Dec 12, 2024
Merged

chore: Update blunderbuss.yml #3934

merged 1 commit into from
Dec 12, 2024

Conversation

jackwotherspoon
Copy link
Contributor

Forgot about blunderbuss.yml when updating CODEOWNERS in #3931

Moving away from infra-db-sdk and using new cloud-sql-connectors group

@jackwotherspoon jackwotherspoon requested review from a team as code owners December 12, 2024 14:26
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jackwotherspoon and reviewers,

I'm currently reviewing this pull request and will post my full review in a few minutes. In the meantime, here's a quick summary to get everyone up to speed:

This PR updates the .github/blunderbuss.yml file to reflect the change from using the infra-db-sdk group to the new cloud-sql-connectors group for Cloud SQL API issues and pull requests. Specifically, lines 29 and 58 in .github/blunderbuss.yml were changed to update the assignee group for Cloud SQL API related issues and pull requests from GoogleCloudPlatform/infra-db-sdk to GoogleCloudPlatform/cloud-sql-connectors. This was missed in a previous PR (#3931) and this PR corrects that oversight. The changes are straightforward and ensure consistent code ownership.

This is a small but important fix to maintain the accuracy of our issue and PR assignment process. It ensures that the correct team is notified and assigned to Cloud SQL API related work.


A tiny poem for your coding pleasure:

Small change, big impact,
A simple fix, a smoother flow,
Code's song now sings true.

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Dec 12, 2024
Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jackwotherspoon,

I'm currently reviewing this pull request and will have a full review for you in a few minutes. In the meantime, here's a quick summary to help you and other reviewers get up to speed.

This PR updates the .github/blunderbuss.yml file to reflect the change from using the infra-db-sdk group to the new cloud-sql-connectors group for Cloud SQL API issues and pull requests. Specifically, lines 29 and 58 in .github/blunderbuss.yml are modified to update the assignee group for 'api: cloudsql' labels from GoogleCloudPlatform/infra-db-sdk to GoogleCloudPlatform/cloud-sql-connectors. This ensures that the correct team is assigned to these issues and pull requests going forward.

This is a small but important change to maintain the accuracy of issue and PR assignments. It addresses an oversight in a previous PR (#3931).


A tiny poem to brighten your day:

Code flows like a river,
Changes merge, a gentle tide,
Bugs swim to the sea.

Thanks!

Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change updates the blunderbuss.yml file to use the cloud-sql-connectors group instead of infra-db-sdk for assigning issues and pull requests related to Cloud SQL. This is a small but important change to ensure that the correct team is notified about relevant issues and PRs. The PR description clearly explains the reason for the change. It would be beneficial to add more context within the blunderbuss.yml file itself, as suggested below.

@@ -26,7 +26,7 @@ assign_issues_by:
- labels:
- 'api: cloudsql'
to:
- GoogleCloudPlatform/infra-db-sdk
- GoogleCloudPlatform/cloud-sql-connectors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Adding a comment here to explain why the team responsible for the 'api: cloudsql' label changed would be helpful for future maintainers. This also helps confirm that the change is intentional and not a typo.

Suggested change
- GoogleCloudPlatform/cloud-sql-connectors
- GoogleCloudPlatform/cloud-sql-connectors # Team responsible for Cloud SQL API

@@ -55,7 +55,7 @@
- labels:
- 'api: cloudsql'
to:
- GoogleCloudPlatform/infra-db-sdk
- GoogleCloudPlatform/cloud-sql-connectors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

Similar to the previous suggestion, adding a comment here explaining the team change would improve context and maintainability.

Suggested change
- GoogleCloudPlatform/cloud-sql-connectors
- GoogleCloudPlatform/cloud-sql-connectors # Team responsible for Cloud SQL API

Copy link
Contributor

@code-review-assist-experimental code-review-assist-experimental bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request updates the blunderbuss.yml file to use the new cloud-sql-connectors group for assigning issues and pull requests labeled with api: cloudsql. This change correctly reflects the move away from the infra-db-sdk group. The change is small and straightforward, and the description clearly explains the reason for the update. No changes to the README files are necessary as this is an internal configuration change.

@@ -26,7 +26,7 @@ assign_issues_by:
- labels:
- 'api: cloudsql'
to:
- GoogleCloudPlatform/infra-db-sdk
- GoogleCloudPlatform/cloud-sql-connectors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

This change looks good. Just confirming, is the cloud-sql-connectors group set up and ready to receive notifications?

@@ -55,7 +55,7 @@
- labels:
- 'api: cloudsql'
to:
- GoogleCloudPlatform/infra-db-sdk
- GoogleCloudPlatform/cloud-sql-connectors
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

This change is consistent with the update for issue assignment. Is there any reason to handle PR and issue assignments differently for the api: cloudsql label?

@iennae iennae merged commit 66798d2 into main Dec 12, 2024
133 checks passed
@iennae iennae deleted the jackwotherspoon-patch-1 branch December 12, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants