Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (data_catalog) migrate region tag in createFilesetEntry.js #3948

Merged
merged 5 commits into from
Jan 20, 2025

Conversation

hivanalejandro
Copy link
Contributor

@hivanalejandro hivanalejandro commented Jan 14, 2025

Description

Migrate region "datacatalog_create_fileset_tag" to "data_catalog_create_fileset_tag"

Fixes b/389810838

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@hivanalejandro hivanalejandro requested review from a team as code owners January 14, 2025 13:44
Copy link

snippet-bot bot commented Jan 14, 2025

Here is the summary of changes.

You are about to add 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added the samples Issues that are directly related to samples. label Jan 14, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi team,

I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:

This pull request, submitted by @hivanalejandro, aims to fix issue b/389810838 by migrating the region tag in the createFilesetEntry.js file within the datacatalog/cloud-client directory. Specifically, the tag datacatalog_create_fileset_tag is being renamed to data_catalog_create_fileset_tag.

Here's a breakdown of the changes:

  • File Changed: datacatalog/cloud-client/createFilesetEntry.js
  • Changes: The pull request modifies lines 29-30 and 104-105 of createFilesetEntry.js. The change involves updating the comment tags to reflect the new naming convention. The // [START datacatalog_create_fileset_tag] and // [END datacatalog_create_fileset_tag] comments are updated to include // [START data_catalog_create_fileset_tag] and // [END data_catalog_create_fileset_tag] respectively. This ensures consistency and correctness in the documentation.

The author has included a checklist to ensure all necessary steps have been followed, including testing and linting. The PR also references the relevant contributing guidelines and style guides.


A little poem to brighten your day:

A tag's name changed,
A subtle fix, yet clean,
Docs now shine anew.

Thanks,
Gemini

@product-auto-label product-auto-label bot added the api: datacatalog Issues related to the Data Catalog API. label Jan 14, 2025
Copy link
Contributor

@code-review-assist code-review-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request migrates the region tag to a new name. The provided code changes look correct and effectively address the issue of the typo in the region tag.

@@ -26,6 +26,7 @@ const main = async (
entryGroupId,
entryId
) => {
// [START data_catalog_create_fileset_tag]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new region tag should only appear once.

Suggested change
// [START data_catalog_create_fileset_tag]
// [START data_catalog_create_fileset_tag]

@@ -101,6 +102,7 @@

console.log(response);
// [END datacatalog_create_fileset_tag]
// [END data_catalog_create_fileset_tag]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The new region tag should only appear once.

Suggested change
// [END data_catalog_create_fileset_tag]
// [END data_catalog_create_fileset_tag]

@glasnt glasnt merged commit aa2a1e7 into main Jan 20, 2025
15 checks passed
@glasnt glasnt deleted the hivanalejandro-migrate-region-step1-389810838 branch January 20, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: datacatalog Issues related to the Data Catalog API. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants