-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: (data_catalog) migrate region tag in createFilesetEntry.js #3948
Conversation
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi team,
I'm currently reviewing this pull request and will provide my feedback shortly. In the meantime, here's a summary for you and other reviewers to quickly get up to speed:
This pull request, submitted by @hivanalejandro, aims to fix issue b/389810838 by migrating the region tag in the createFilesetEntry.js
file within the datacatalog/cloud-client
directory. Specifically, the tag datacatalog_create_fileset_tag
is being renamed to data_catalog_create_fileset_tag
.
Here's a breakdown of the changes:
- File Changed:
datacatalog/cloud-client/createFilesetEntry.js
- Changes: The pull request modifies lines 29-30 and 104-105 of
createFilesetEntry.js
. The change involves updating the comment tags to reflect the new naming convention. The// [START datacatalog_create_fileset_tag]
and// [END datacatalog_create_fileset_tag]
comments are updated to include// [START data_catalog_create_fileset_tag]
and// [END data_catalog_create_fileset_tag]
respectively. This ensures consistency and correctness in the documentation.
The author has included a checklist to ensure all necessary steps have been followed, including testing and linting. The PR also references the relevant contributing guidelines and style guides.
A little poem to brighten your day:
A tag's name changed,
A subtle fix, yet clean,
Docs now shine anew.
Thanks,
Gemini
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request migrates the region tag to a new name. The provided code changes look correct and effectively address the issue of the typo in the region tag.
@@ -26,6 +26,7 @@ const main = async ( | |||
entryGroupId, | |||
entryId | |||
) => { | |||
// [START data_catalog_create_fileset_tag] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -101,6 +102,7 @@ | |||
|
|||
console.log(response); | |||
// [END datacatalog_create_fileset_tag] | |||
// [END data_catalog_create_fileset_tag] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Migrate region "datacatalog_create_fileset_tag" to "data_catalog_create_fileset_tag"
Fixes b/389810838
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.