Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for OTLP k8s ingest with auto-instrumentation #114

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

psx95
Copy link
Contributor

@psx95 psx95 commented Jan 22, 2025

This PR adds a recipe to showcase the use of OpenTelemetry Operator with self managed OTLP collector configured to export to Google Cloud.

The operator adds and manages the instrumentation for the sample Java app (instrumentation-quickstart app).

The instrumentation is configured to export traces to the self-managed collector.

@psx95 psx95 force-pushed the gke-autoinstrument branch 2 times, most recently from 3d5699d to 3085749 Compare January 23, 2025 17:19
@psx95 psx95 marked this pull request as ready for review January 23, 2025 17:21
@psx95 psx95 requested a review from a team as a code owner January 23, 2025 17:21
@psx95 psx95 requested a review from dashpole January 23, 2025 17:21
Copy link
Contributor

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great overall

recipes/self-managed-otlp-ingest/README.md Show resolved Hide resolved
recipes/self-managed-otlp-ingest/README.md Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/README.md Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/README.md Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/README.md Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/instrumentation.yaml Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/instrumentation.yaml Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/instrumentation.yaml Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/instrumentation.yaml Outdated Show resolved Hide resolved
recipes/self-managed-otlp-ingest/k8s/quickstart-app.yaml Outdated Show resolved Hide resolved
@dashpole
Copy link
Contributor

I would recommend adding a region tag to the Instrumentation.yaml so that we can reference it from GCP documentation

@psx95
Copy link
Contributor Author

psx95 commented Jan 24, 2025

Looking great overall

Thanks for the detailed review. I will make the necessary changes.

@psx95 psx95 force-pushed the gke-autoinstrument branch from 3085749 to 52d58fe Compare January 24, 2025 22:48
psx95 added 2 commits January 24, 2025 22:52
Updates the instrumentation to rely more on the defaults
@psx95 psx95 force-pushed the gke-autoinstrument branch from 630c838 to d816f65 Compare January 25, 2025 19:07
The generated traffic results in telemetry being produced from the
application.
@psx95 psx95 force-pushed the gke-autoinstrument branch from d816f65 to fdfad6c Compare January 25, 2025 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants