Use beyla metrics directly for golden signals #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were using the spanmetrics connector to generate the metrics. Now Beyla supports annotating k8s metadata on metrics directly and we can use the metrics it produces instead of annotating in the collector.
aabmass
force-pushed
the
beyla-golden-frommetrics
branch
from
e2e3cda to
5dbea3f
Compare
aabmass
commented
Feb 28, 2024
dashpole
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were using the spanmetrics connector to generate the metrics. Now Beyla supports annotating k8s metadata on metrics directly and we can use the metrics it produces instead of annotating in the collector.
Applications dashboard with this change:
