Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples: cert-manager podmonitoring manifest #408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ajayk
Copy link
Contributor

@ajayk ajayk commented Jan 5, 2023

Add an example for the basic cert-manager podmonitoring manifest to scrape the cert-manager metrics

@ajayk
Copy link
Contributor Author

ajayk commented Jan 10, 2023

@pintohutch : ^^

@pintohutch pintohutch requested a review from yqlu January 13, 2023 17:07
@pintohutch
Copy link
Collaborator

Thanks for the contribution @ajayk.

@yqlu - what's our policy here? Should new examples also come with a yaml snippet (example) of what the actual exporter setup should look like in addition to any PodMonitoring?

@pintohutch pintohutch requested a review from lyanco January 13, 2023 19:12
@yqlu
Copy link
Collaborator

yqlu commented Jan 13, 2023

Hi @ajayk

Thanks for the contribution!

Let's flesh out the README a bit more -- the other examples here link to documentation in which we try to guide the user through the whole process of integrating an application with Managed Service with Prometheus. The podmonitoring config is only one part of the puzzle. Can you include:

  1. a link to cert-manager itself (https://cert-manager.io/)
  2. a sample yaml snippet or instructions on how to configure cert-manager to export prometheus-format metrics. I haven't worked with cert-manager, but I found the following through a quick search:
  3. guidance on how to verify (2) is working -- for example, our Airflow instructions document how to run kubectl port-forward ... and access the port to check that metrics are available at that endpoint.
  4. podmonitoring -- you have this, great!
  5. guidance on how to verify that metrics are correctly ingested into GMP (again, refer to our published docs that ask the user to navigate to Metrics Explorer and run a given query.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants