Natively support probe (blackbox) monitoring (MVP) #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSpiritXIII
added a commit
that referenced
this pull request
Jan 30, 2024
After NodeMonitoring was added, when it is configured, target status stops working completely. Long story short, the problem is early exit on an unknown scrape pool format. This change includes some refactoring originally part of the ProbeMonitoring PR (#766) but also adds in the possibility of supporting a NodeMonitoring target status if we choose to add it in the future, by at the very least detecting and validating the scrape pool format. Changes include: - Ensures we still patch everything on error (with new unit test case). - Show all errors, not just the last one we found. - Ensures we parse NodeMonitoring scrape pool formats (with new unit test case). - Validate expected errors in the test cases. Thanks @bwplotka for finding this issue!
TheSpiritXIII
added a commit
that referenced
this pull request
Jan 30, 2024
After NodeMonitoring was added, when it is configured, target status stops working completely. Long story short, the problem is early exit on an unknown scrape pool format. This change includes some refactoring originally part of the ProbeMonitoring PR (#766) but also adds in the possibility of supporting a NodeMonitoring target status if we choose to add it in the future, by at the very least detecting and validating the scrape pool format. Changes include: - Ensures we still patch everything on error (with new unit test case). - Show all errors, not just the last one we found. - Ensures we parse NodeMonitoring scrape pool formats (with new unit test case). - Validate expected errors in the test cases. Thanks @bwplotka for finding this issue!
TheSpiritXIII
added a commit
that referenced
this pull request
Jan 30, 2024
After NodeMonitoring was added, when it is configured, target status stops working completely. Long story short, the problem is early exit on an unknown scrape pool format. This change includes some refactoring originally part of the ProbeMonitoring PR (#766) but also adds in the possibility of supporting a NodeMonitoring target status if we choose to add it in the future, by at the very least detecting and validating the scrape pool format. Changes include: - Ensures we still patch everything on error (with new unit test case). - Show all errors, not just the last one we found. - Ensures we parse NodeMonitoring scrape pool formats (with new unit test case). - Validate expected errors in the test cases. Thanks @bwplotka for finding this issue!
TheSpiritXIII
added a commit
that referenced
this pull request
Jan 30, 2024
After NodeMonitoring was added, when it is configured, target status stops working completely. Long story short, the problem is early exit on an unknown scrape pool format. This change includes some refactoring originally part of the ProbeMonitoring PR (#766) but also adds in the possibility of supporting a NodeMonitoring target status if we choose to add it in the future, by at the very least detecting and validating the scrape pool format. Changes include: - Ensures we still patch everything on error (with new unit test case). - Show all errors, not just the last one we found. - Ensures we parse NodeMonitoring scrape pool formats (with new unit test case). - Validate expected errors in the test cases. Thanks @bwplotka for finding this issue!
maxamins
pushed a commit
that referenced
this pull request
Feb 1, 2024
After NodeMonitoring was added, when it is configured, target status stops working completely. Long story short, the problem is early exit on an unknown scrape pool format. This change includes some refactoring originally part of the ProbeMonitoring PR (#766) but also adds in the possibility of supporting a NodeMonitoring target status if we choose to add it in the future, by at the very least detecting and validating the scrape pool format. Changes include: - Ensures we still patch everything on error (with new unit test case). - Show all errors, not just the last one we found. - Ensures we parse NodeMonitoring scrape pool formats (with new unit test case). - Validate expected errors in the test cases. Thanks @bwplotka for finding this issue!
TheSpiritXIII
force-pushed
the
TheSpiritXIII/probe-monitoring
branch
from
04d473b to
ec1f2db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #91.
Special thanks to @bernot-dev who collaborated with me on this feature.
This PR adds native managed probe monitoring. A few features are intentionally missing in this MVP: