Skip to content

Commit

Permalink
Merge pull request #661 from rfbgo/zero_phase_warn
Browse files Browse the repository at this point in the history
Warn if no phases are exec across all experiments
  • Loading branch information
douglasjacobsen authored Sep 25, 2024
2 parents 46fafee + a5b2c74 commit ffd1122
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions lib/ramble/ramble/pipeline.py
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,8 @@ def _execute(self):
logger.all_msg(f" Log files for experiments are stored in: {self.log_dir}")

count = 1
phase_total = 0

for exp, app_inst, idx in self._experiment_set.filtered_experiments(self.filters):
exp_log_path = app_inst.experiment_log_file(self.log_dir)

Expand Down Expand Up @@ -166,6 +168,7 @@ def _execute(self):
f"Processing phase {phase} ({phase_idx}/{len(phase_list)})"
)
app_inst.run_phase(self.name, phase, self.workspace)
phase_total += 1
if not disable_progress:
progress.update()
app_inst.print_phase_times(self.name, self.filters.phases)
Expand All @@ -176,8 +179,12 @@ def _execute(self):
logger.remove_log()
if not self.suppress_per_experiment_prints:
logger.all_msg(f" Returning to log file: {logger.active_log()}")

count += 1

if phase_total == 0:
logger.warn("No valid phases were selected, please verify requested phases")

def _complete(self):
"""Hook for performing pipeline actions after execution is complete"""
pass
Expand Down

0 comments on commit ffd1122

Please sign in to comment.